Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github_server.yml #845

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Update github_server.yml #845

merged 2 commits into from
Jan 2, 2024

Conversation

miabonardi
Copy link
Contributor

@miabonardi miabonardi commented Jan 1, 2024

In this PR, I have:

  • Added tests for any new features or bug fixes (if relevant)
  • Added my changes to the CHANGELOG.md at the top, under the "Unreleased" section
  • Ensured issues that this PR closes will be automatically closed

Reason for this PR

Updated github server yml comments with plocket to make workflow clearer

Links to any solved or related issues

N/A

Any manual testing I have done to ensure my PR is working

N/A

Copy link
Collaborator

@plocket plocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great, thanks! You can merge it when you're ready! It would also be great if you'd link the relevant issue (#840) to this PR so that it'll get closed automatically, but that's not required. Let me know if you want to know more about that.

@miabonardi miabonardi linked an issue Jan 2, 2024 that may be closed by this pull request
@miabonardi miabonardi merged commit 7961921 into v5 Jan 2, 2024
6 checks passed
@plocket plocket deleted the update-github-server-yml branch January 2, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow setup user feedback
2 participants