Close #831, allow author to delete interviews from interview list #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because AL experimentally removed its `users[0]` question and that may be a temporary change
not all authors will give their ALKiln account admin permissions, (which is what we recommend anyway) so they can only delete their own interviews
API key permissions, testing whether interviews have been deleted.
workflows to include new env vars, create env vars on GitHub.
...deleting interviews is per user, so the dev api key is irrelevant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have:
Reason for this PR
Until now, interview sessions that the tests created were left on the server. Now, a test that logs in as a user can delete their interview session as long as the author also includes that user's API key in the "start interview" Step.
Adjusts repo's workflows and secrets to include new information. This means we should probably update the instructions for new collaborators. For the github_server workflow, that meant creating a low-level user in the new container to log in, and delete interviews, separately from the admin user. I currently don't remember what test that broke. It was something about the admin user being able to see all interviews and delete all interviews.
Also adjusts log code tests to ignore feature files, or any files in the ALKilnTests folder, when checking for codes. That way, our feature tests can check that output/reports have the correct log codes. Still need to change "tests/log_codes/check_codes.sh" to "check_codes.sh" to work properly in GitHub workflows.
Switched to adding our own
users[0]question because of changes in Assembly Line.Links to any solved or related issues
Closes #831
Any manual testing I have done to ensure my PR is working
Visually confirmed that interviews were created and then deleted on the server.