Smaller refactors #153
Merged
Smaller refactors #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were directly saving and using the FilingTypeType enum, which comes from Tyler's ECF4 extension. With ECF 5 coming up, we should separate it into a generic enum. Takens from working ECF 5 code branch.
Adds comments to existing functions, and a new function. `exists` is a good shorthand for `val != null && !val.isBlank()` when used in one liners.
Collections can be sets or lists, making it easier to list all possible choices, without duplicates.
Makes the interface for the various database classes that we use AutoCloseable. This results in a lot of small changes everywhere, as we don't have to access the underlying Connection object for convience functions or to close it. As a result of some of these changes, we also start giving Services a `Supplier<CodeDatabase>`. This also preps for ECF5; the CodesDatabase will have two implementations, one for ECF4 and one for ECF5, but the services won't know which to use without lots of extra configs or globals. So instead we simply give them a Supplier, that they can call and use as normal; the constructing object knows which of ECF4 vs ECF5 to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the
ecf5branch is very big, and unfortunately not all of it is related to ECF 5; lots of other smaller refactors snuck in there, and not all of them are directly related to ECF 5 stuff.This PR splits out a few parts that:
Ran integration tests locally and they run great. The database commit is touches many different parts of the code, so integration tests are the only good tests here.