Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch filer_type #158

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Patch filer_type #158

merged 2 commits into from
Sep 21, 2023

Conversation

BryceStevenWilley
Copy link
Collaborator

Follow up to 6ea4e90

  • We were still expecting the API callers to pass the "name" of the code, not the code itself. This was refactored for all other codes a long time ago, and this makes filer_type consistent with everything else (see Officially no longer sending over names for tyler things  #82)
  • one of the SQL columns is default, which is also a SQL keyword. Need to put the column name in double quotes for PostgreSQL to be happy

@BryceStevenWilley
Prevents error on filer_type table SELECT
63935c6 
Postgres doesn't like when you use keywords as column names. To prevent any
errors, wrap them in double quotes.
@BryceStevenWilley
FilerType should compare to code
00683b1 
Just like everything else does. Must have gotten lost in the great name to code
change of 2021.
@BryceStevenWilley BryceStevenWilley merged commit ea38646 into main Sep 21, 2023
3 checks passed
@BryceStevenWilley BryceStevenWilley deleted the patch_filer branch September 21, 2023 15:46
@BryceStevenWilley BryceStevenWilley mentioned this pull request Sep 21, 2023
Merged
BryceStevenWilley added a commit to SuffolkLITLab/docassemble-EFSPIntegration that referenced this pull request Sep 21, 2023
@BryceStevenWilley
Filer type in Docassemble (#231)
61a948c 
Adds support of the Filer type, an uncommon court code used (and required) in some Texas jurisdictions.

* adds a method to get the types from the EfileProxy endpoint
* adds a default question, with things to fill it in if there aren't any or only one `filer_types`
* misc addition to the `any_filing_interview`, to not let you try to make an initial filing when the court won't let you
 
Corresponding PR is EfileProxy: SuffolkLITLab/EfileProxyServer#158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BryceStevenWilley