Fix mypy typing issues #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpy 2.0 released and can cause some potential issues, so restrict to 1.x.y for now. * `docx.Document` is a constructor function, `docx.document.Document` is the type itself * Some unused weirdness in `get_possible_radios` popped up: the function is untested, so I fixed the typing issues
|
Mypy looks good now, nice! Does the build failure need a look? |
See #135, I'm cooking up a fix in ALActions (SuffolkLITLab/ALActions#25 and SuffolkLITLab/ALActions#26) that I think should solve it and not mess with anything else. |
BryceStevenWilley
added a commit
to SuffolkLITLab/ALActions
that referenced
this pull request
Jun 17, 2024
Use the build-constraints.txt file when building all repos, to avoid using numpy 2 which can break spacy. Continues on the work done in #25. --- Tested on SuffolkLITLab/FormFyxer#136.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 2.0 released and can cause some potential issues, so restrict to 1.x.y for now.
docx.Documentis a constructor function,docx.document.Documentis the type itselfget_possible_radiospopped up: the function is untested, so I fixed the typing issuesIf this passes, I'll merge and then merge some fixes into
pdf_content_extractand #134.