don't cut off text for addendum in mid-word

[nonprofittechy]

Fix #243

Sample interactive test:

---
modules:
  - .al_document
---
mandatory: True
code: |
  text_input
  display_results
---
objects:
  - myfield: ALAddendumField.using(field_name="text_input")
---
question: |
  Enter some text
fields:
  - Overflow trigger: myfield.overflow_trigger
    datatype: integer
  - Text: text_input
    datatype: area
    rows: 5
---
event: display_results
question: |
  Results
subquestion: |
  
  ${ single_to_double_newlines(myfield.safe_value(overflow_message="...", preserve_newlines=True, preserve_words=True)) }
  
  ${ single_to_double_newlines(myfield.overflow_value(overflow_message="...", preserve_newlines=True, preserve_words=True)) }
  

[BryceStevenWilley]

IMO it needs a little more tests, I'm not sure I understand what textwrap does to multi-line input, which text areas are likely to get often

[BryceStevenWilley]

Not sure how this would interact with newlines in value, which people are likely to add in text areas I think.https://docs.python.org/3/library/textwrap.html#textwrap.TextWrapper.replace_whitespace says that it'll "cause strange output", which makes me a little hesitant.

[nonprofittechy]

It doesn't cause strange output in our usage, which ends up removing the line breaks after any get added.

We just use textwrap.wrap to figure out how many lines should fit, but we let the pdf renderer handle the actual soft line breaks in the output.

[BryceStevenWilley]

We aren't removing all of the line breaks, we're just collapsing things where multiple appear in a row. Test overflow of 90, and input:

At least 10% of people 

in this target audience do not know what this term means.
 
Therefore, you must avoid this term, explain this term, or link to an explanation.

Results in 3 lines of text, when there should only be 2, because there are still some \ns inside the input text. Extra lines like that could cause things to get cut off in the PDF by pushing the last line below the height of the text box, right?

[nonprofittechy]

Tricky to test this given different way that whitespace (particularly newlines) happen in-browser input fields vs in a docstring in the unit test file, but I think this is all correct now! This now also fixes some minor, undiscovered but long-standing bugs in the addendum code too.

[BryceStevenWilley]

LGTM. The only weird thing was that preserve_newlines isn't really respected if max_lines < 1, but that makes sense IMO, maybe worth documenting, but up to you.

[nonprofittechy]

LGTM. The only weird thing was that preserve_newlines isn't really respected if max_lines < 1, but that makes sense IMO, maybe worth documenting, but up to you.

I'm going to add some better documentation on the public documentation site