Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't force gathering users[0].address to gather users[1].address or users[0].mailing_address #639

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Don't force gathering users[0].address to gather users[1].address or users[0].mailing_address #639

merged 1 commit into from
Dec 12, 2022

Conversation

nonprofittechy
Copy link
Member

Fix #636

BryceStevenWilley
BryceStevenWilley approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@BryceStevenWilley BryceStevenWilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unfortunate that we need defined("users[0].address.address") in there multiple times, but oh well.

@nonprofittechy nonprofittechy merged commit a6baad4 into main Dec 12, 2022
@nonprofittechy nonprofittechy deleted the dont-trigger-users0-address branch December 12, 2022 21:46
@BryceStevenWilley BryceStevenWilley mentioned this pull request Dec 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryceStevenWilley BryceStevenWilley BryceStevenWilley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't always ask for user[0].address before other users
2 participants
@nonprofittechy @BryceStevenWilley