Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use exports to import react component #74

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

docs: use exports to import react component #74

wants to merge 1 commit into from

Conversation

giuem
Copy link

@giuem giuem commented May 18, 2022

No description provided.

SukkaW
SukkaW reviewed May 18, 2022
View reviewed changes
Copy link
Owner

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript's support for the Node.js compatible exports map is still in beta.

@giuem
Copy link
Author

giuem commented May 25, 2022 •
edited
Loading

TypeScript 4.7 already released. Shall we followup and set package.json's type to module?

@SukkaW
Copy link
Owner

SukkaW commented May 25, 2022

TypeScript 4.7 already released. Shall we followup and set package.json's type to module?

You have to use moduleResolution: nodenext in order to use Node.js exports map in TypeScript, which is still unstable. So no, not yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giuem @SukkaW