Complete homework 10-10-10 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crkingsley
requested review from
johnny-rice,
Shanifos,
Kayla-SA-W,
itsdanielguerrero,
DDiggs0798,
sashgems and
orbitalbitmap
johnny-rice
reviewed
Jul 14, 2020
| @@ -12,68 +12,191 @@ | |||
| @Example - Sending the function a value of 10 will result in 11 | |||
| @Test - Write a console.log that shows the value of `increaseLevel(10)` | |||
| */ | |||
| function increaseLevel(number) { | |||
There was a problem hiding this comment.
Nice naming and commenting.
johnny-rice
reviewed
Jul 16, 2020
|
|
||
| console.log(makeEchoesOne(5)) | ||
| */ | ||
| function makeEchoesTwo(numberRepeats) { |
johnny-rice
approved these changes
Jul 16, 2020
| string = string + msg; | ||
| // the number of repeats (5) is equal to the number of repeats - 1 | ||
| numberRepeats = numberRepeats - 1 | ||
| // the number of repeats equals 4 |
|
|
||
| /* | ||
| @Challenge 04 - Write a function named `showTheFifties` that loops from 1 to 200. | ||
| function showMeTheMoney(dollars) { |
| Use a condition in the loop to console.log the number when it is over 49 and under 60 | ||
| @Example - Expect to see 50, 51, 52, 53, 54, 55, 56, 57, 58, 59 in the terminal | ||
| @Test - Make a function call of `showTheFifties()` | ||
| */ | ||
|
|
||
| /* | ||
| function showTheFifties(vintageItem) { |
There was a problem hiding this comment.
✅ ✅ I like the parameter naming
| // if variable is greater than 0, continue to for loop | ||
| if (vintageItem > 0) { | ||
| // loop 0 to 200, increasing by an increment of 1 | ||
| for (let i = 0; i < 200; i++) { |
There was a problem hiding this comment.
Just a note. This loops to 199 instead of to 200.
| @Challenge 05 - Write a function that returns an array that is named `getTheTwenties` that loops from 1 to 60 and returns an array of all the 20's | ||
| Use a condition in the loop to push to an array when the number is greater than or equal to 20 and under 30 | ||
| @Example - Expect an array returned with value of [20, 21, 22, 23, 24, 25, 26, 27, 28, 29] | ||
| @Test - console.log the result of a function call of `getTheTwenties()` and expect to see an array value of [20, 21, 22, 23, 24, 25, 26, 27, 28, 29] | ||
| */ | ||
|
|
||
| /* | ||
| function getTheTwenties(twenties) { |
| sayin: 'I am a crow!' | ||
| } | ||
| ] | ||
| function getEveryLittleThing(arr) { |
There was a problem hiding this comment.
Lots of great effort in here practicing array methods. I love to see it. ✅ ✅
| console.log(letters) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
✅ I like the use of forEach
| "4 Gallons Remaining" | ||
| "3 Gallons Remaining" | ||
| "2 Gallons Remaining" | ||
| "1 Gallons Remaining" | ||
| in the terminal | ||
| @Test - Make a function call of `trackGallonsUsed(5)` | ||
| */ | ||
| function trackGallonsUsed(gallons) { |
| // set the count to equal gallons remaining + the message | ||
| count = gallons + msg; | ||
| // reduce the number of gallons by 1 | ||
| gallons -= 1 |
There was a problem hiding this comment.
Nice use of the shorthand -=
| @Challenge 10 - Write a function named `getHighScore` that finds the highest value in an array of scores | ||
| @Example - Sending the function a value of [1999,2020,3080,1111] will result in 3080 | ||
| @Test - Write a console.log that shows the value of `getHighScore([1999,2020,3080,1111])` | ||
| */ | ||
|
|
||
| function getHighScore(score) { | ||
| // found this Math.max which is supposed to |
There was a problem hiding this comment.
Great comment. Thanks for adding it.
Math.max(...[1999, 2020, 3080, 1111]) is a similar use as well. I was thinking everyone would solve this with a loop. I like this unique solution. Great work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.