Answer #1
Open
Answer #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hollisjamison
requested review from
johnny-rice,
DDiggs0798,
itsdanielguerrero,
Kayla-SA-W,
orbitalbitmap,
sashgems and
Shanifos
johnny-rice
approved these changes
Jul 21, 2020
| if (inputLineup.length > 9) return false | ||
|
|
||
|
|
||
| // calculate our total salary, if it's more than %45,000 return false and exit function |
There was a problem hiding this comment.
Simple and accurate. Nice work!
| // make an array of every result we are looking for | ||
| const allResults = array.map(array => array[propertyName]) | ||
| // now trim all results and get each unique value | ||
| const uniqueResults = [...new Set(allResults)] |
|
|
||
| }); | ||
|
|
||
| // now check our array to see if there are more then allowed |
| let otherArray = players.filter(player => player != 'OF') | ||
|
|
||
| // now we check if our OF count is correct and our players are all unique positions and there are 6 of them | ||
| // if all 3 is true then we have 3 OF and a P, C, 1B, 2B, 3B, and SS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.