Add support for compression (gzip and deflate) #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
frankreno,
samjsong,
vsinghal13 and
perk-sumo
samjsong
approved these changes
Apr 8, 2020
lib/fluent/plugin/out_sumologic.rb
Outdated
| desc 'Compress payload' | ||
| config_param :compress, :bool, :default => false | ||
| desc 'Encoding method of compresssion (either gzip or deflate)' | ||
| config_param :compress_encoding, :string, :default => SumologicConnection::COMPRESS_DEFLATE |
There was a problem hiding this comment.
I'm not too familiar with these, what was our reason for defaulting to deflate vs gzip?
There was a problem hiding this comment.
I would say consistency with logstash plugin:
Deflate seems to be more compact (shorter header) and faster.
Gzip includes additional headers and data validation, but uses deflate underneath
There was a problem hiding this comment.
Also gzip looks to be preferred by HTTP society
There was a problem hiding this comment.
After some research I changed it to gzip. We can always change it back before release
sumo-drosiek
force-pushed
the
drosiek-compression
branch
from
1b7497d to
9f37538
Compare
sumo-drosiek
pushed a commit
that referenced
this pull request
Apr 8, 2020
sumo-drosiek
added a commit
that referenced
this pull request
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for compression basing on logstash plugin
https://github.com/SumoLogic/logstash-output-sumologic/blob/master/lib/logstash/outputs/sumologic/compressor.rb