-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove axios from dependencies due to reported security vulnerability causing false alert #78
Comments
- See vulnerability SumoLogic#78 for details
- See issue SumoLogic#78 for details
- Due to vulnerability CVE-2019-10742 - See issue SumoLogic#78 for details
I have submitted PR #79 to fix this issue. |
Thanks @erikeckhardt but we are removing Axios in favor of SuperAgent. Not sure why the line for Axios was left in the package but I will file a new PR removing it shortly. |
- Was replaced with SuperAgent - Due to vulnerability CVE-2019-10742 causing package managers and github to trigger a security alert - See issue SumoLogic#78 for details
That's a perfectly acceptable solution. Just for convenience, I've updated my PR to remove that as well, if you feel like merging it. |
Removed Axios in #80. |
Ah, I see you've already created and merged your own. Pity, as I could easily have updated my PR for you. Thanks for taking care of it! Do you expect a patch release soon? |
Yes, just triggered the script. |
Vulnerability CVE-2019-10742 in npm package axios has been identified in the National Vulnerability Database.
Because axios is still listed in dependencies of js-sumo-logger, code depending on js-sumo-logger is getting flagged as having a security vulnerability.
This issue is thus for tracking removing axios from the dependency.
For more information from the axios side:
The text was updated successfully, but these errors were encountered: