Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent throwing when batchSize and raw specified #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srolel
Copy link

@srolel srolel commented Feb 3, 2021

when both are specified, the JSON.parse call throws.

@safaiyeh
Copy link
Contributor

Appreciate the PR @srolel can you rebase with master so we can run the latests tests on your PR. Then we can merge this in.

@srolel
Copy link
Author

srolel commented Aug 21, 2021

Appreciate the PR @srolel can you rebase with master so we can run the latests tests on your PR. Then we can merge this in.

Done!

@bpolanczyk
Copy link
Contributor

Hi @srolel!
I'm sorry for the delay, but I'm picking up the repository for maintenance after a period of hiatus.

Are you sure that the ternary operator isn't flipped, though? Your change means that we'd never use JSON.parse() on string, actually.
As for the change, once we settle on the solution, I can merge and release it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants