Improve no timezone db error (#289)

* Wrap error from time.LoadLocation to include reason

* time zone -> timezone

* Remove timezone database suggestion

operator/builtin/parser/syslog/syslog.go

@@ -75,7 +75,7 @@ func (c SyslogParserConfig) Build(context operator.BuildContext) ([]operator.Ope
 
 	location, err := time.LoadLocation(c.Location)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("failed to load location %s: %w", c.Location, err)
 	}
 
 	syslogParser := &SyslogParser{

operator/builtin/parser/syslog/syslog_test.go

@@ -20,6 +20,7 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/require"
+	"go.uber.org/zap"
 	"gopkg.in/yaml.v2"
 
 	"github.com/open-telemetry/opentelemetry-log-collection/entry"
@@ -101,3 +102,13 @@ parse_to: $.to`
 		require.Equal(t, expect, &actual)
 	})
 }
+
+func TestSyslogParserInvalidLocation(t *testing.T) {
+	config := NewSyslogParserConfig("test")
+	config.Location = "not_a_location"
+	config.Protocol = RFC3164
+
+	_, err := config.Build(operator.NewBuildContext(zap.NewNop().Sugar()))
+	require.Error(t, err)
+	require.Contains(t, err.Error(), "failed to load location "+config.Location)
+}

operator/helper/time.go

@@ -115,7 +115,7 @@ func (t *TimeParser) setLocation() error {
 		// If "location" is specified, it must be in the local timezone database
 		loc, err := time.LoadLocation(t.Location)
 		if err != nil {
-			return err
+			return fmt.Errorf("failed to load location %s: %w", t.Location, err)
 		}
 		t.location = loc
 		return nil
@@ -198,7 +198,7 @@ func (t *TimeParser) parseGotime(value interface{}) (time.Time, error) {
 	loc, locErr := time.LoadLocation(zone)
 	if locErr != nil {
 		// can't correct offset, just return what we have
-		return result, err
+		return result, fmt.Errorf("failed to load location %s: %w", zone, locErr)
 	}
 
 	// Reparse the timestamp, with the location

operator/helper/time_test.go

@@ -736,3 +736,24 @@ func defaultTimeCfg() *TimeParser {
 	newCfg := NewTimeParser()
 	return &newCfg
 }
+
+func TestSetInvalidLocation(t *testing.T) {
+	tp := NewTimeParser()
+	tp.Location = "not_a_location"
+	err := tp.setLocation()
+	require.Error(t, err)
+	require.Contains(t, err.Error(), "failed to load location "+"not_a_location")
+}
+
+func TestParseGoTimeBadLocation(t *testing.T) {
+	tp := NewTimeParser()
+	tp.Location = "America/New_York"
+
+	err := tp.setLocation()
+	require.NoError(t, err)
+
+	tp.Layout = time.RFC822
+	_, err = tp.parseGotime("02 Jan 06 15:04 BST")
+	require.Error(t, err)
+	require.Contains(t, err.Error(), "failed to load location BST")
+}