Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exporter/syslog)!: replace syslog exporter with syslog exporter from opentelemetry-collector-contrib #1341

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

kasia-kujawa
Copy link
Contributor

Fixes #1200

@kasia-kujawa kasia-kujawa requested a review from a team as a code owner November 21, 2023 10:34
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 21, 2023
Copy link
Contributor

@aboguszewski-sumo aboguszewski-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create another PR to deprecate the syslog exporter we're dropping now?

docs/upgrading.md Outdated Show resolved Hide resolved
@kasia-kujawa kasia-kujawa force-pushed the kk-replace-syslogexporter branch from 6a58780 to 84f7a21 Compare November 21, 2023 10:53
@kasia-kujawa kasia-kujawa force-pushed the kk-replace-syslogexporter branch from 84f7a21 to ffecbf2 Compare November 21, 2023 11:28
@kasia-kujawa kasia-kujawa changed the title feat(syslogexporter)!: replace syslog exporter with syslog exporter from opentelemetry-collector-contrib feat(exporter/syslog)!: replace syslog exporter with syslog exporter from opentelemetry-collector-contrib Nov 21, 2023
@kasia-kujawa
Copy link
Contributor Author

Can you create another PR to deprecate the syslog exporter we're dropping now?

@aboguszewski-sumo thanks! please check #1342

docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
docs/upgrading.md Outdated Show resolved Hide resolved
@@ -45,7 +45,7 @@ In order to learn more, pleasee see [purpose of Sumo Logic Distribution for Open
## Supported OS and architectures

| Linux | MacOS | Windows |
| ----------------------------- | ----------------------------- | --------------------------- |
|-------------------------------|-------------------------------|-----------------------------|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're using different Markdown (table) formatters 😅 What is the formatter you use locally?

@kasia-kujawa kasia-kujawa force-pushed the kk-replace-syslogexporter branch from ffecbf2 to 4d66d89 Compare November 23, 2023 15:11
@kasia-kujawa kasia-kujawa force-pushed the kk-replace-syslogexporter branch from 4d66d89 to d91019c Compare November 27, 2023 09:24
@kasia-kujawa kasia-kujawa merged commit 0ced85e into main Nov 27, 2023
28 checks passed
@kasia-kujawa kasia-kujawa deleted the kk-replace-syslogexporter branch November 27, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace syslog exporter with syslog exporter from opentelemetry-collector-contrib
3 participants