feat: add Dockerfile and Makefile target to build UBI based sidecar container image #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek-sumo
reviewed
Jul 28, 2021
kasia-kujawa
force-pushed
the
kk-ubi-based-sidecar-image
branch
from
fc5c3c4 to
82690f5
Compare
pmalek-sumo
reviewed
Jul 28, 2021
sidecar/Makefile
Outdated
Comment on lines
18
to
19
| docker build --tag $(TAG) --build-arg VERSION=${VERSION} --build-arg RELEASE_NUMBER=${RELEASE_NUMBER} \ | ||
| --file ${root_dir}sidecar/Dockerfile.ubi ${root_dir}sidecar/ |
There was a problem hiding this comment.
Formatting nitpick for readability
Suggested change
| docker build --tag $(TAG) --build-arg VERSION=${VERSION} --build-arg RELEASE_NUMBER=${RELEASE_NUMBER} \ | |
| --file ${root_dir}sidecar/Dockerfile.ubi ${root_dir}sidecar/ | |
| docker build \ | |
| --tag $(TAG) \ | |
| --build-arg VERSION=${VERSION} \ | |
| --build-arg RELEASE_NUMBER=${RELEASE_NUMBER} \ | |
| --file ${root_dir}sidecar/Dockerfile.ubi ${root_dir}sidecar/ |
sidecar/Dockerfile.ubi
Outdated
|
|
||
| LABEL name="Tailing Sidecar" \ | ||
| maintainer="collection@sumologic.com" \ | ||
| vendor="sumologic" \ |
There was a problem hiding this comment.
Suggested change
| vendor="sumologic" \ | |
| vendor="SumoLogic" \ |
?
There was a problem hiding this comment.
I think that we should write company name as "Sumo Logic". What do you think?
There was a problem hiding this comment.
🤔 might be. We'd have to change the labels in other images as well
kasia-kujawa
force-pushed
the
kk-ubi-based-sidecar-image
branch
from
82690f5 to
c7ef90f
Compare
kasia-kujawa
force-pushed
the
kk-ubi-based-sidecar-image
branch
from
c7ef90f to
cdff540
Compare
pmalek-sumo
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example command to build image: