Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support config leader election #550

Merged
merged 1 commit into from
Jul 3, 2023
Merged

support config leader election #550

merged 1 commit into from
Jul 3, 2023

Conversation

Frapschen
Copy link
Contributor

The same as operator-framework/operator-sdk#1813 (comment), I encounter leader election lost.

We can increasing the LeaseDuration, RenewDeadline and RetryPeriod like opentelemetry-operator

@Frapschen Frapschen requested a review from a team as a code owner June 27, 2023 02:49
@JaredTan95
Copy link
Contributor

you can also upgrade the helm chart.

@sumo-drosiek
Copy link
Contributor

@Frapschen thank you for the PR

Could you move configuration to config.go? We would like to use configuration file instead of command line arguments. Also I don't see a reason to expose all command line arguments. We can limit to the election ones

you can also upgrade the helm chart.

We are releasing as separate pull requests:

https://github.com/SumoLogic/tailing-sidecar/blob/a1fd0a8f32f5ff7ce790d5b717175152999cf95b/docs/release.md

@JaredTan95
Copy link
Contributor

We are releasing as separate pull requests:
https://github.com/SumoLogic/tailing-sidecar/blob/a1fd0a8f32f5ff7ce790d5b717175152999cf95b/docs/release.md

OK, I mean that should also upgrade the content templates/*.yaml in the chart, not bump up chart version:-P

JaredTan95
JaredTan95 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sumo-drosiek
sumo-drosiek reviewed Jun 27, 2023
View reviewed changes
operator/config.go Outdated Show resolved Hide resolved
@Frapschen Frapschen force-pushed the support_config_leader_election branch from 6f32f07 to 4f84815 Compare June 30, 2023 02:34
@sumo-drosiek sumo-drosiek merged commit f21acb4 into SumoLogic:main Jul 3, 2023
@Frapschen Frapschen deleted the support_config_leader_election branch July 4, 2023 06:33
This was referenced Jul 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@JaredTan95 JaredTan95 JaredTan95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Frapschen @JaredTan95 @sumo-drosiek