Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support config replicaCount #555

Merged

Conversation

Frapschen
Copy link
Contributor

No description provided.

@Frapschen Frapschen requested a review from a team as a code owner July 4, 2023 06:53
@sumo-drosiek
Copy link
Contributor

@Frapschen Thank you for the PR. Could you add check if leaderElection is enabled in case of replicaCount > 1 and fail otherwise?

@Frapschen
Copy link
Contributor Author

@sumo-drosiek Is there a release plan?

@sumo-drosiek
Copy link
Contributor

@sumo-drosiek Is there a release plan?

We can release after the merge

@sumo-drosiek
Copy link
Contributor

sumo-drosiek commented Jul 4, 2023

@Frapschen Thank you for the PR. Could you add check if leaderElection is enabled in case of replicaCount > 1 and fail otherwise?

I was thinking more like about approach we have in Sumo Logic Kubernetes Collection (using fail function)

please see the following example:

{{/* Check if metrics provider is set to either fluentd or otelcol */}}
{{- if not (or (eq .Values.sumologic.metrics.metadata.provider "fluentd") (eq .Values.sumologic.metrics.metadata.provider "otelcol")) -}}
{{- fail "\nsumologic.metrics.metadata.provider should be set to either fluentd or otelcol" -}}
{{- end -}}

@Frapschen Frapschen requested a review from sumo-drosiek July 5, 2023 06:52
@sumo-drosiek sumo-drosiek merged commit 2c06d03 into SumoLogic:main Jul 5, 2023
@Frapschen Frapschen deleted the helm_support_config_replicacount branch July 6, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants