Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUMO-227092: Terraform support for azure source #626

Merged
merged 13 commits into from
May 14, 2024

Conversation

yyyttthan99
Copy link
Contributor

@yyyttthan99 yyyttthan99 commented Feb 23, 2024

Addressed comments in #590. Closing the last pr since the base branch is too old.

I was able to create the source with the dev build and acceptance tests can pass now.

@yyyttthan99 yyyttthan99 added the collection Item is related to data collection aspect of Sumo Logic. label Feb 23, 2024
@yyyttthan99 yyyttthan99 self-assigned this Feb 23, 2024
@yyyttthan99 yyyttthan99 force-pushed the SUMO-227092-azure-source-terraform branch from 09cf2e3 to dea6bcc Compare March 4, 2024 22:25
…form-fix-env

Sumo 227092 azure source terraform fix env
@yyyttthan99
Copy link
Contributor Author

Thanks Vijit for bringing up the Sensitive field here regarding the issue with password field. I tried that one but unfortunately even with Sensitive to true, it doesn't function properly and we will still have the same issue. Existing fields like secret_key in S3 and private_key in GCP metrics are all using plain text, so I think this behavior is acceptable for share_access_policy_key as well.

We had discussions about cutoffTimestamp in slack and weekly sync. To summarize, with current changes, user can only update cutoffTimestamp to a non-zero value with tf, this is a discrepancy in tf that we have to live with. If users do want to update cutoffTimestamp to 0, they can do it via API, which we believe is a very rare case and to achieve "Collection from Now", user can alternatively just give the exact epoch timestamp of Now. And we have confirmed ingestion won't be affected.

Copy link
Collaborator

@maimaisie maimaisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check with Damo in #collection-rwc-dev-qe to see if QE needs to do testing on new TF source? If needed can they squeeze this in for S2?

@yyyttthan99
Copy link
Contributor Author

Can I get one more approval for this PR? Thanks! cc @samjsong @vsinghal13 @yuting-liu

Copy link
Contributor

@yuting-liu yuting-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. One small question

@yyyttthan99
Copy link
Contributor Author

Any need to modify the polling source's terraform documentation while we change scan_interval to optional?

Thanks Yuting for reviewing. Even though we make the scan_interval optional, I am inclined to not exposing this change to customer. The reason is that this change is only for us to handle scan_interval properly, customers don't need to do any changes for azure sources or their existing sources (s3 etc). Besides, I feel it's good practice for the customer to specify scan_interval explicitly. Wdyt?

@yyyttthan99 yyyttthan99 merged commit 2278855 into master May 14, 2024
3 checks passed
@yyyttthan99 yyyttthan99 deleted the SUMO-227092-azure-source-terraform branch May 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collection Item is related to data collection aspect of Sumo Logic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants