Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csre 183 adding data forwarding resource #678

Merged
merged 16 commits into from
Sep 18, 2024

Conversation

Aqz2024
Copy link
Collaborator

@Aqz2024 Aqz2024 commented Aug 7, 2024

Added S3 data forwarding support to the terraform provider.

Slack Conversation - link

  • The tests are failing because of this issue, hence we are not adding the test as a part of this PR. We have locally ran the tests and they are passing, so we will add those tests right after the above issue is fixed.

Documentation

@janek-sumo
Copy link

janek-sumo commented Aug 8, 2024

Can you add more context to the PR description? References to the Sumo Logic documentation for the resource would be helpful.

There are multiple types of data forwarding. This resource is just for the S3 forwarding, right? That should be made clear, perhaps even in the resource name.

@namangoya namangoya self-requested a review August 19, 2024 18:26
Copy link
Collaborator

@namangoya namangoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@namangoya namangoya merged commit bd9ed6b into master Sep 18, 2024
5 checks passed
@namangoya namangoya deleted the CSRE-183_Adding_Data_Forwarding_Resource branch September 18, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants