Merge pull request #377 from Sunagatov/bug/default-review-filter

Removed null check for GetReviewsRequestValidator
Sunagatov · Sep 12, 2024 · 5397a30 · 5397a30
2 parents e1e16d0 + b26edc7
commit 5397a30
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/main/java/com/zufar/icedlatte/review/validator/GetReviewsRequestValidator.java b/src/main/java/com/zufar/icedlatte/review/validator/GetReviewsRequestValidator.java
@@ -38,10 +38,6 @@ public void validate(final Integer pageNumber,
 
     private StringBuilder validateProductRatingsParameter(final List<Integer> productRatings) {
         final StringBuilder errorMessages = new StringBuilder();
-        if (productRatings == null) {
-            String errorMessage = String.format("product's rating is required. Allowed 'productRating' values are '%s'.", ALLOWED_PRODUCT_RATING_VALUES);
-            errorMessages.append(createErrorMessage(errorMessage));
-        }
         if ((productRatings != null && productRatings.stream().anyMatch(Objects::isNull))
                 || (productRatings != null && !ALLOWED_PRODUCT_RATING_VALUES.containsAll(productRatings))) {
             String errorMessage = String.format("Some values of this product's rating list = '%s' are incorrect. Allowed 'productRating' values are '%s'.",

diff --git a/src/test/java/com/zufar/icedlatte/review/endpoint/ProductReviewEndpointTest.java b/src/test/java/com/zufar/icedlatte/review/endpoint/ProductReviewEndpointTest.java
@@ -21,6 +21,7 @@
 import static com.zufar.icedlatte.test.config.RestAssertion.assertRestApiBadRequestResponse;
 import static com.zufar.icedlatte.test.config.RestAssertion.assertRestApiBodySchemaResponse;
 import static com.zufar.icedlatte.test.config.RestAssertion.assertRestApiNotFoundResponse;
+import static com.zufar.icedlatte.test.config.RestAssertion.assertRestApiOkResponse;
 import static com.zufar.icedlatte.test.config.RestUtils.getJwtToken;
 import static com.zufar.icedlatte.test.config.RestUtils.getRequestBody;
 import static io.restassured.RestAssured.given;
@@ -159,8 +160,8 @@ void shouldFetchReviewStatsSuccessfully() {
 
 
     @Test
-    @DisplayName("Reviews and ratings with default pagination and sorting for unauthorized user. Should return 400 Bad Request")
-    void shouldReturnBadRequestForDefaultPaginationAndSortingForAnonymous() {
+    @DisplayName("Reviews and ratings with default pagination and sorting for unauthorized user. Should return 200 OK")
+    void shouldSuccessfullyReturnReviewsForDefaultPaginationAndSortingForAnonymous() {
         // No authorization is required
         specification = given()
                 .log().all(true)
@@ -172,7 +173,7 @@ void shouldReturnBadRequestForDefaultPaginationAndSortingForAnonymous() {
         Response response = given(specification)
                 .get("/{productId}/reviews", AMERICANO_ID);
 
-        assertRestApiBadRequestResponse(response, FAILED_REVIEW_SCHEMA);
+        assertRestApiOkResponse(response, REVIEWS_WITH_RATINGS_RESPONSE_SCHEMA);
     }
 
     @Test