Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IL-84]Environments #92

Merged
merged 30 commits into from
Sep 30, 2023
Merged

[IL-84]Environments #92

merged 30 commits into from
Sep 30, 2023

Conversation

voltwatt
Copy link

Adding environment profiles to pom.xml

Copy link
Owner

@Sunagatov Sunagatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

.env Show resolved Hide resolved
public class AppHealthCheckTest {

@Test
public void isAppAlive() throws Exception {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this unit test can help us?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test quickly validates that the application container is running and the web server is reachable, so we know we can start coding against it. While the test is simple, it can catch glaring issues like if the server isn't running or is misconfigured, which saves debugging time later. Although this is a basic test, it serves as a foundation for more complex health checks in the future.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
src/test/java/AppHealthCheckTest.java Outdated Show resolved Hide resolved
src/test/java/AppHealthCheckTest.java Outdated Show resolved Hide resolved
src/test/java/AppHealthCheckTest.java Outdated Show resolved Hide resolved
@gitguardian
Copy link

gitguardian bot commented Sep 11, 2023

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 7cbe425 src/main/resources/application.yaml View secret
- Generic High Entropy Secret 0a05203 src/main/resources/application.properties View secret
- Generic High Entropy Secret 41ef0d4 src/main/resources/application.properties View secret
- Generic High Entropy Secret 7cbe425 src/main/resources/application.properties View secret
- Generic High Entropy Secret 0a05203 src/main/resources/application.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@oldo1013 oldo1013 changed the title Environments [IL-84]Environments Sep 13, 2023
@Sunagatov Sunagatov merged commit f6f3c9f into Sunagatov:development Sep 30, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants