Fb/asset ownership transfer api #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinukumar-vs
suggested changes
May 29, 2024
|
|
||
| function handelAssetOwnershiptransfer(req, err){ | ||
| var rspObj = req.rspObj | ||
| console.log('User transferAssetOfDeleteduser failed', JSON.stringify(err)) |
There was a problem hiding this comment.
Remove these console logs, and user proper logger object.
There was a problem hiding this comment.
Why are printing the error log as soon as method hits.
| var rspObj = req.rspObj | ||
| console.log('User transferAssetOfDeleteduser failed', JSON.stringify(err)) | ||
| if(err && err.response && err.response.data) { | ||
| console.log(`User transferAssetOfDeleteduser err ==> ${req.params.userId} ==>`, JSON.stringify(err.response.data)); |
There was a problem hiding this comment.
User Logger object and remove console.log
| console.log(`User transferAssetOfDeleteduser err ==> ${req.params.userId} ==>`, JSON.stringify(err.response.data)); | ||
| } | ||
| const errCode = userMessages.DELETE.OWNERSHIP_TRANSFER_FAIL; | ||
| rspObj.errCode = userMessages.DELETE.FAILED_CODE; |
There was a problem hiding this comment.
Is this DELETE.FAILED_CODE?
Check the error messages.
| try { | ||
| KafkaService.sendRecordWithTopic(req.rspObj.request, envVariables.COKREAT_USER_DELETE_KAFKA_TOPIC, function (err, res) { | ||
| if (err) { | ||
| handelAssetOwnershiptransfer(req, err); |
There was a problem hiding this comment.
The method name is not proper. You are not having the positive scenario here.
User the right method name lik "owershipTransferErrorHandler"
vinukumar-vs
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: