Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create SunKit.yml #56

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Create SunKit.yml #56

merged 2 commits into from
Nov 3, 2024

Conversation

davideilmito
Copy link
Collaborator

No description provided.

@davideilmito davideilmito added the enhancement New feature or request label Nov 2, 2024
seldon1000
seldon1000 reviewed Nov 2, 2024
View reviewed changes
Copy link
Member

@seldon1000 seldon1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when new Xcode versions are available?

@davideilmito
Copy link
Collaborator Author

davideilmito commented Nov 2, 2024 •
edited
Loading

Since @retroactive keyword has been added on latest commit it is necessary to run the build through an Xcode version 16 or higher. A new Xcode version will be forced if new keywords/function will not be anymore compatible with Xcode 16.1.

@davideilmito
Copy link
Collaborator Author

@seldon1000 I think we shall keep @retroactive keyword in order to not have any warnings. It's ok to stick with Xcode 16.1 to run test and build.

seldon1000
seldon1000 approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@seldon1000 seldon1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideilmito davideilmito merged commit a18a6f7 into main Nov 3, 2024
1 check passed
@seldon1000
Copy link
Member

The @retroactive keyword was added to Date's extension of Strideable to silence a warning in Xcode 16+ releases. Given that it is unlikely that warning will cause any trouble, we could consider reverting that change instead of merging this PR. This way, we could theoretically keep retro-compatibility with previous versions of Xcode.

Otherwise, if you think it's appropriate to move forward with this PR, I'll proceed approving your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldon1000 seldon1000 seldon1000 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davideilmito @seldon1000