Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: there is 400ms delay between when a new chat arrived and when the chat is scrolled down. #24

Open
sync-by-unito bot opened this issue Aug 18, 2020 · 12 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 18, 2020

  • need to also test this with a space with many messages with uploaded messages
  • also test with newly sent messages with pdf/images attached the scroll should go to bottom.

Description for test:

  • Receive multiple messages in chat
  • You will see that new messages are arrived, but scroll to bottom happened only after more than 400ms

┆Attachments: meeting card.PNG | new message scroll.mp4 | attachment scroll.mp4

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 19, 2020

➤ Ray Gerami commented:

@anton Barabanov ( https://app.asana.com/0/922257708030355/calendar ) this should also fix this issue: #25 ⁃ [Anton] System loganstaging2.esna.com - Chat/Quick chat/DM - Unable to scroll down to see new messages ( https://app.asana.com/0/1179813771897518/1184808038555100 )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 19, 2020

➤ Ray Gerami commented:

FYI: this is not a blocker, we just made it a blocker to bring more focus.

@anton
Copy link

anton commented Aug 19, 2020

➤ Ray Gerami commented:

@anton Barabanov ( https://app.asana.com/0/922257708030355/calendar ) this should also fix this issue: #25 ⁃ [Anton] System loganstaging2.esna.com - Chat/Quick chat/DM - Unable to scroll down to see new messages ( https://app.asana.com/0/1179813771897518/1184808038555100 )

Hi Ray. I can see that you have highlighted my nick. I have no clue what you are asking for here because I am not involved in the mentioned project.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 19, 2020

➤ Ray Gerami commented:

HI Songlin, you don't need to do anything here, Anton will review this PR

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 19, 2020

➤ Anton Barabanov commented:

Verified locally. PR looks good.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 26, 2020

➤ Muhammad Saad Amjad commented:

@ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) is this task regarding the blue banner user sees when the user is scrolled in the chat and receives a new message?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 26, 2020

➤ Vincent Yeung commented:

https://drive.google.com/file/d/1JaqoGsXVzafSyJRKd8XmzZkJ2AN8WQZY/view
@ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) so far i am able to tell the difference in terms of responsiveness from sending msge to sender, however there is an issue with sending recordings and starting meeting in which the meeting card isnt scrolled all the way down. Both of these are on production as well. Should we create a new task instead to track those or do you want to keep this task?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 26, 2020

➤ Muhammad Saad Amjad commented:

@ray Gerami ( https://app.asana.com/0/1154145881585295/calendar )@anton Barabanov ( https://app.asana.com/0/922257708030355/calendar ) meeting card is also cut off until the user joins the meeting. I expect this will require the similar fix as this task.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 26, 2020

➤ Umair Aslam commented:

@anton Barabanov ( https://app.asana.com/0/922257708030355/calendar ) Hi Anton. Can you please add some testing instructions for QC? Details like current behaviour and expected behaviour will be very helpful.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 27, 2020

➤ Anton Barabanov commented:

@Umair Aslam ( https://app.asana.com/0/1153071673779409/calendar ), added description

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 27, 2020

➤ Muhammad Saad Amjad commented:

@anton Barabanov ( https://app.asana.com/0/922257708030355/calendar )@ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) please review the attached video

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 27, 2020

➤ Ray Gerami commented:

@Muhammad Saad Amjad ( https://app.asana.com/0/1173029421672619/list ), what happens after the preview is ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant