Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Anton] System loganstaging2.esna.com - Chat/Quick chat/DM - Unable to scroll down to see new messages #25

Closed
sync-by-unito bot opened this issue Aug 18, 2020 · 24 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 18, 2020

Problem description (be as specific as possible), include step by step procedure used to reproduce the issue:
User sends some chat and attaches some files, user send more chat and now the scroll bar can go down to the bottom and disappears. User's unable to scroll down to bottom and unable to see new chat messages.

Notes:
- This issue also happens with quick chat

  • This issue happens with : chrome, firefox, safari, edge
  • This issue does not happens on system: spaces.avayacloud.com
    - Refresh page does not fix the issue

Setup:
UserA - Any user

Steps:

  1. UserA sends some messages
  2. UserA shares some files
  3. UserA sends some more messages

Expected :
All messages are fully displayed. UserA can scroll down to bottom to see new messages

Actual:
Scrolling bar disappear at the bottom. User is not able to scroll down to see latest messages

Workaround: N/A

SV comment for blocking status: yes

Is the issue reproducible: 100%

┆Attachments: loganstaging2.esna.com-1594887508553.log | Screenshot_3.png | Video_2020-07-16_151810.mp4 | loganstaging2.esna.com-1594897619628.log | Screenshot_1.png | Video_2020-07-16_180629.mp4 | image.png | loganstaging.esna.com-1594950703583.log | Screenshot_2.png | Video_2020-07-17_085123.mp4 | loganstaging.esna.com-1594978784768.log | Screenshot_1.png | Video_2020-07-17_163857.mp4 | Screenshot_1.png | Screenshot_2.png | spaces-candidate.avayacloud.com-1595403937413.log | Video_2020-07-22_144510.mp4 | Screenshot_1.png | Screenshot_2.png | spaces-candidate.avayacloud.com-1595823014485.log | Video_2020-07-27_110955.mp4

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Tho Pham commented:

My Meeting Room has the same issue but on the opposite site. That user's unable to scroll to top

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Jeff Yu commented:

ready for merge

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Umair Aslam commented:

Merged.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Sonali Patel commented:

Hey guys i got the same issue by script .
Steps:

  1. Use shares multiple of files
    Actual : User is not able to scroll down to see latest file so cannot validate file name in chat tab

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Tho Pham commented:

Hi @jeff Yu ( https://app.asana.com/0/1179813771897518/calendar )@Umair Aslam ( https://app.asana.com/0/1153071673779409/calendar ) I has quick retested this issue on loganstaing.esna.com ( https://loganstaing.esna.com ) and here's the results:

  • Group space/Quick Chat: Passed if user uses attach button to attach files. Failed if user drag and drop to attach files
  • My Meeting Room: Passed if user uses drag and drop. Failed if user uses attach button to attach files

@sonali Patel ( https://app.asana.com/0/1173040346099684/list ) please help to retest your case on loganstaging.esna.com ( https://loganstaging.esna.com ) again. If issue still happens, please add log, screenshot so that dev team can investigate. Thanks.

Please check new screenshot, log and video clip for My Meeting Room

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Tho Pham commented:

This log, screenshot and video clip are for Group space/DM

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Jeff Yu commented:

Please see PR - https://github.com/esna/spaces-front/pull/3017

Scrollbar is still buggy, this fix only solve some part of the issue, recommend to get original author to take a look.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Tho Pham commented:

@jeff Yu ( https://app.asana.com/0/1179813771897518/calendar ) the fix is not good enough for customers use. After attached files are uploaded, the scroll bar is moved to bottom but attached files are not shown fully. User has to scroll more to see hidden content and timestamp. Please check the fix again.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Jeff Yu commented:

@anton Barabanov ( https://app.asana.com/0/922257708030355/calendar ) This is quite difficult to debug, i saw you have done a lot of changes recently, can you take a look plz?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Anton Barabanov commented:

PR: https://github.com/esna/spaces-front/pull/3043

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Jeff Yu commented:

@tho Pham ( https://app.asana.com/0/1151199909755310/list ) I've reviewed PR, however it still couldn't meet the requirement 100% - sometimes attached file not showing fully

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Anton Barabanov commented:

@jeff Yu ( https://app.asana.com/0/1179813771897518/calendar ), could you attach video, where requirement is not met and that file please and return then back to me?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Jeff Yu commented:

The video is already attached by thinhhn check 7-22.mp4

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Anton Barabanov commented:

@jeff Yu ( https://app.asana.com/0/1179813771897518/calendar ), could you attach the file with what you have a problem please?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Jeff Yu commented:

@thinhhn ( https://app.asana.com/0/1170464762469262/list ) Can you re-attach a video for Anton plz.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Tho Pham commented:

Hi @anton Barabanov ( https://app.asana.com/0/922257708030355/calendar )@jeff Yu ( https://app.asana.com/0/1179813771897518/calendar ),

I still get the same issue which commented 5 days ago that attached files are not shown fully although the scroll bar is at bottom. User has to scroll more to see complete/other files as well as timestamp. Please check new log, screenshot and video clip below.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 18, 2020

➤ Umair Aslam commented:

As per @anton Barabanov ( https://app.asana.com/0/922257708030355/calendar ) the issue is reproducible on production for pdf files. Changed priority to high.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 19, 2020

➤ Ray Gerami commented:

@anton Barabanov ( https://app.asana.com/0/922257708030355/calendar ), this PR should fix it on #24 ⁃ FE: there is 400ms delay between when a new chat arrived and when the chat is scrolled down. ( https://app.asana.com/0/0/1189615630697905 )
https://github.com/esna/spaces-front/pull/3317

@anton
Copy link

anton commented Aug 19, 2020

➤ Jeff Yu commented:

@anton Barabanov ( https://app.asana.com/0/922257708030355/calendar ) This is quite difficult to debug, i saw you have done a lot of changes recently, can you take a look plz?

Hi. I can see that you have highlighted my nick. I have no clue what you are asking for here because I am not involved in the mentioned project.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 19, 2020

➤ Anton Barabanov commented:

Verified locally. PR looks good.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 20, 2020

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 24, 2020

➤ Ray Gerami commented:

@anton Barabanov ( https://app.asana.com/0/922257708030355/calendar ), is this PR still valid after the work done on spacecalling with new messages are showing.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 25, 2020

➤ Anton Barabanov commented:

@ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ), I've checked locally on latest candidate and on loganstaging.esna.com. Seems problem is not reproduced anymore and we can close the PR.

@sync-by-unito sync-by-unito bot closed this as completed Aug 26, 2020
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 26, 2020

➤ Tho Pham commented:

Verified and passed on spaces-candidate.avayacloud.com. Close this item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant