Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release pyDARNio v1.1 #21

Merged
merged 26 commits into from
May 25, 2021
Merged

Release pyDARNio v1.1 #21

merged 26 commits into from
May 25, 2021

Conversation

mts299
Copy link
Collaborator

@mts299 mts299 commented Apr 30, 2021

Scope

The new feature is reading/writing Borealis v0.6.

Documentation:

Changes:

  • reading/writing Borealiss 0.6
  • reading partial Map records
  • fixed Borealis Slive interface

Approvals

3 - all testing and reviewing. Please state on approval what OS and python version you used.

DEADLINE: May 17, 2021

Testing

  • general install
  • general reading DMAP and Borealis files
  • reading/writing Borealiss 0.6
  • reading partial Map records
  • Borealis Slive interface

Please ask @kevinkrieger where to get Borealis files to test on

kevinkrieger and others added 21 commits December 11, 2020 21:55
…asIq/Rawrf and moved the current latest classes to v05.

test_borealis.py: Added placeholders for test files for v06 for rawrf, bfiq, rawacf and antennas_iq.
Added Test class for v06 for BorealisRead. Updated test class for BorealisConvert to have v06 tests. WIP
Co-authored-by: mardet987 <mardet987@users.noreply.github.com>
Update naming of lp_status_word
fix typo in agc_status_word
Parsing functions for phase encoding needed adjustments to handle new
structure.

More sample blanking was added in v0.6 so the check needed adjustment.

fixed some conflicts with the gps_time type.
@mts299 mts299 self-assigned this Apr 30, 2021
@mts299 mts299 requested a review from billetd April 30, 2021 20:02
@Lozzy-Bear Lozzy-Bear assigned Lozzy-Bear and unassigned Lozzy-Bear May 14, 2021
@carleyjmartin
Copy link
Collaborator

carleyjmartin commented May 14, 2021

I'm having trouble installing, I'm making a venv and then tried:
pip3 install git+https://github.com/superdarn/pyDARNio@release/v1.1
that didn't work so I also tried the clone then pip3 install . --user way, that didnt work so I tried the python setup.py install way.
They all just hang until I tell it to quit.
on the first way, It hangs after:

Collecting git+https://github.com/superdarn/pyDARNio@release/v1.1
  Cloning https://github.com/superdarn/pyDARNio (to revision release/v1.1) to /private/var/folders/fw/0wyj_jf501l_gj69h6dn009w0000gn/T/pip-req-build-7dw0v5ap
  Running command git clone -q https://github.com/superdarn/pyDARNio /private/var/folders/fw/0wyj_jf501l_gj69h6dn009w0000gn/T/pip-req-build-7dw0v5ap
  Running command git checkout -b release/v1.1 --track origin/release/v1.1
  Switched to a new branch 'release/v1.1'
  Branch 'release/v1.1' set up to track remote branch 'release/v1.1' from 'origin'.

I don't know if that helps or not, but I'm a bit stuck if I can't install it :P

Edit: this is on Mac

@Lozzy-Bear
Copy link
Collaborator

Lozzy-Bear commented May 14, 2021 via email

Copy link
Collaborator

@RemingtonRohel RemingtonRohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OS: OpenSUSE Leap 15.2
Python Version: 3.6.12

Copy link
Collaborator

@carleyjmartin carleyjmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • general install
    Install problems just went away and now I can install it with no issue?

  • general reading DMAP and Borealis files
    Read older rawacf and bfiq borealis files using BorealisRead()
    Read dmap rawacf file using DmapRead()

  • reading/writing Borealiss 0.6
    Used BorealisConvert() to convert a new borealis rawafc file to a dmap.
    Assuming that you're not supposed to be able to us BorealisRead() on v6 files as I get a structural error?

I don't know how to test these two?

  • reading partial Map records
  • Borealis Slive interface

OS: Mac Catalina 10.15.5
Python: 3.7.3

@mts299
Copy link
Collaborator Author

mts299 commented May 20, 2021

don't worry about the last two @RemingtonRohel did a good job on it. Map one is tricky since you need to find a partial record in a file which is not easy. The slice interface is you read an array file in and convert to a slice file or you call on records? @RemingtonRohel can you explain?

@RemingtonRohel
Copy link
Collaborator

Yes, the slice interface (actually the method unshared_fields_dims_site, @mts299 mentioned to me) is called when you access the records property of either a BorealisArrayRead or BorealisArrayWrite object. So basically just read a Borealis Array file and access the records.
For the partial map record, I installed pyDARN v1.0.0 in a virtual environment and tried to read in a map file from 1993, then caught the exception and tried reading it with pyDARNio.

Copy link
Collaborator

@Lozzy-Bear Lozzy-Bear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows 10 x86-64
Python 3.7.10

OpenSUSE 15.2
Python 3.8.5

Copy link
Collaborator

@Devin-Huyghebaert Devin-Huyghebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the templates. There are some minor suggestions.

Was able to read in the data for the files that @RemingtonRohel posted. Did not test the other formats.

Example code:
`import pydarnio

sd_rawacf = pydarnio.BorealisRead('data/20210225.2219.22.sas.0.rawacf.hdf5.site', 'rawacf', 'site')

print(sd_rawacf.records)
`

OS: Ubuntu 20.04.2 LTS
Python 3.8.5

.github/ISSUE_TEMPLATE/discussion_template.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/discussion_template.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/documentation_template.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_template.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_template.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_template.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_template.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/question_template.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/question_template.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/question_template.md Outdated Show resolved Hide resolved
mts299 and others added 4 commits May 25, 2021 05:55
@mts299 mts299 merged commit 88ab3c2 into master May 25, 2021
@mts299 mts299 deleted the release/v1.1 branch May 25, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants