-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature: IQ Data Plots #338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
RemingtonRohel
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like this a lot! There are some minor things in the code that I think would be good to change, but otherwise I was able to plot some iqdat data very easily.
* Fixed a bug with raising NoDataFoundError in plotting.py find_record() method * Using ax parameters in methods of IQ class * Added some whitespace in parameter default values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
This PR has a new plotting module for IQ data. There are four types of plots, time-series, single sequence, single record and an overview plot for the IQ data.
Does include documentation changes, but we can test that works when we build the docs before a release.
Anyway, I wasn't really sure what people wanted when they asked to just plot IQ data so if you had different ideas of what was important let me know and we can add it.
Note:
chnnum
in the data is NOT related to frequency channels used.chnnum
is the number of different channels in the IQ data: that means main array and interferometer array (chnnum=2) NOT the frequency channels.issue: to close #320
Approval
Number of approvals: 2 at least, lots of things
Test
matplotlib version: 3.7.1
Note testers: please indicate what version of matplotlib you are using
If you would like this IQ data please let me know, but I would like if people can test with different data as this file was a bit weird. It only had beams 6-15 and only for 15 minutes. If you have iq data from a radar with different channels being used, please test!
You can plot main array data when interferometer=False, and interferometer data when =True
Should produce: