Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EHN: Replace GSMR equation #356

Merged
merged 3 commits into from
Nov 23, 2023
Merged

EHN: Replace GSMR equation #356

merged 3 commits into from
Nov 23, 2023

Conversation

carleyjmartin
Copy link
Collaborator

Scope

This pull request replaces the current equation to calculate the GSMR range estimate, and makes a new method for GSMR_BRISTOW which uses the older Bristow GSMR version.
There is also a new warning when inf values are found during the Bristow equation method.

You can read the discussion of this issue at #257

issue: to close #257

Approval

Number of approvals: 2

Test

matplotlib version: 3.7.2
Note testers: please indicate what version of matplotlib you are using

import matplotlib.pyplot as plt 
import pydarn

file = "/Users/carley/Documents/data/20211102.0000.00.rkn.a.fitacf"
SDarn_read = pydarn.SuperDARNRead(file)
fitacf_data = SDarn_read.read_fitacf()

a = pydarn.RTP.plot_summary(fitacf_data, beam_num=2, range_estimation=pydarn.RangeEstimation.GSMR, watermark=False, title='New GSMR Eqn')
plt.show()
a = pydarn.RTP.plot_summary(fitacf_data, beam_num=2, range_estimation=pydarn.RangeEstimation.GSMR_BRISTOW, watermark=False, title='Old GSMR (GSMR_BRISTOW)')
plt.show()
a = pydarn.RTP.plot_summary(fitacf_data, beam_num=2, range_estimation=pydarn.RangeEstimation.SLANT_RANGE, watermark=False, title='Slant Range')
plt.show()

Will give:
Screenshot 2023-09-14 at 12 01 04 PM
Screenshot 2023-09-14 at 12 01 19 PM
Screenshot 2023-09-14 at 12 01 31 PM

For now the warning message will not show up, warnings for summary plots are fixed in another PR.

@carleyjmartin carleyjmartin mentioned this pull request Nov 13, 2023
27 tasks
@carleyjmartin carleyjmartin merged commit 3549ec7 into develop Nov 23, 2023
@carleyjmartin carleyjmartin deleted the ehn/new-gsmr-eqn branch November 23, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Update the position algorithm used for radar gate positioning
1 participant