-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: pyDARN v4.1! #398
Conversation
* This allows overplotting on an axes object
* Changed projections.py so that a user can pass in an already-defined axis with a projection * Changed scan.py to find records in a scan by either scan index or datetime * Refactored fan.py to incorporate the above changes, and allow user to pass in axis object to plot colorbar in. * Refactored all methods in fan.py to staticmethods
Method for calculating the electric potentials at a given coordinate
Calculating potentials at any coordinate
* The default background_alpha is used for calls to plot_range_time and plot_coord_time.
* Was improperly ensuring that the first scan was always scan_index=0, and instead all scans were being assigned as scan_index=0.
Allow user to specify background transparency in RTP calls.
Lots of little changes to customize Fan plots.
Option to output coastline coordinates in magnetlic longitude
things to check if this doesn't work -the way I'm getting the location of the radars -I should probably add the elevation of the radars for the calculation -I'm not sure if I'm sweeping the terminator correctly -somebody smarter than me should probably check this
This reverts commit a07a358.
Co-authored-by: Evan Thomas <evan.g.thomas@dartmouth.edu>
Add alpha to plt.colorbar when using pyplot.contourf
Fixed `map_info=False` not working
NEW: Map Potential Time Series at Given MLON/MLAT
EHN: Flexibility on Plotting Summary Plot Variables
This comment was marked as resolved.
This comment was marked as resolved.
Testing environment: OpenSuse 15.5, numpy 1.26.4, matplotlib 3.9.1, cartopy 0.23.0, pydarn 4.1 I did some testing of fan and fov plots. Tested all plots on POLAR, MAG, and GEO projections, and found no issues with plots generated. Embargo flag is working, as is adjusting the MAG and GEO plot center and extent. Overall didn't find any issues with the fan or fov plots. |
…d auto testing that no longer work
FIX: Dependencies for scipy and pydarnio ahead of release
Testing environment: OpenSuse 15.5, numpy 1.26.4, matplotlib 3.9.1, cartopy 0.23.0, pydarn 4.1 Did some more testing, on grid and map plotting now. Grid plots are working with all projections for both northern and southern hemisphere. Tested plotting each parameter type of the grid file and had no issues. Similar for map plots. Both northern and southern hemisphere plotted fine and I had no issues with any of the keyword options. Each parameter plotted without issue. Also had no issues plotting map time series for various parameters and potential time series parameter worked as expected. |
I've added ruff as an automatic linter for commits and pull requests to this branch and develop (you'll see develop is failing because I've only fixed errors here). |
Testing environment: OpenSuse 15.5, numpy 2.0.1, matplotlib 3.9.1, cartopy 0.23.0, pydarn 4.1 Finished reviewing summary plots / time series plotting as well as hardware files. Changes to summary plotting to allow a subset of parameters to be plotted is working well, and all the RTP plots seem to be working (I don't think there were many if any changes to the RTP plots so I wasn't super thorough). Hardware files for the new NSSC radars are present and I had no issues checking the hardware files or plotting the FOVs of all SuperDARN radars. Also, no issues with newer versions of numpy now. |
Testing environment: OpenSuse 15.5, numpy 2.0.1, matplotlib 3.9.1, cartopy 0.23.0, pydarn 4.1 Also tested ACF plotting with a number of keywords and found no problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing I have run has had no issues.
Testing Environment: Windows 10, numpy 2.0.1, matplotlib 3.9.1, cartopy 0.23.0, pydarn 4.1 Ran the same tests I ran on OpenSuse on my Windows laptop and came across no issues. |
Testing Environment: Windows 10, numpy 1.26.4, matplotlib 3.7.1, cartopy 0.23.0, pydarn 4.1 There are no issues with the new features for the time being, but using Themis mode, sometimes will report an error:" for g, gate in enumerate(matching_records1[i]['slist']): KeyError: 'slist' ". |
Scope
This minor release includes:
scan_time
andscan_time_tolerance
keywordslowlat
default discrepancy fixedDocumentation updates are found here: https://pydarn.readthedocs.io/en/release-v4.1/
Approval
Number of approvals: 3
Please check that you are happy with your inclusion and position in the zenodo files for authorship - and let me know if I forgot anyone!
Test
Before testing this release, please check out the following unmerged PR's if they have been set as ready to review!
#397
We are expecting pyDARNio to be released before this release of pyDARN is ready, if you find you are getting a numpy error when testing, this is fixed in the latest pyDARNio release, is outside the scope of pyDARN so please either downgrade numpy to version 1.26.4 or install the release/develop branch of pyDARNio, thanks!
matplotlib version: 3.7.0 +
numpy version: No restrictions
Cartiopy: 0.22 +
Note testers: please indicate what version of matplotlib, Cartopy and numpy you are using
What needs testing:
For examples of test code, see the readthedocs link above.
For those interested, you can also run the unit tests by installing pytest and running
pytest
from the top directory of a clone of this branch.Deadline
September 6th 2024 - but earlier the better!
Carley's To Do List: