Bugfix/bad records #438
Merged
Bugfix/bad records #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Custom __repr__ for SliceData that should display all variables set * Added a check to write_hdf5_file() that should circumvent the IndexError
|
Currently running on PGR to monitor over the weekend. Hopefully, the warning will log but the files will still pass through the dataflow without issue. |
|
The warning has appeared a few dozen times at PGR since I've pulled the branch there; none of the files have failed to convert or raised exceptions when passed through the data flow. I recommend we proceed with this PR. |
tjk584
approved these changes
Mar 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the intermittent issue in the
developbranch where zero-sequence records throw anIndexErrorwhen being written to file.write_hdf5_file()indata_write.pythat will circumvent the IndexError.__repr__method that won't fail due to missing attributes, and instead prints all attributes set.