Cfs refactor #513
Merged
Cfs refactor #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All internal cfs-related variables in CFSAveragingPeriod are dicts, keyed by slice_id
RemingtonRohel
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes since the branch was last merged to develop.
Added a
base pulse phase offsetcalculation that will add a pulse phase offset based on the slice frequency and the tau spacing of the pulses. This offset isn't saved to file as it is present in all data due to an artifact of frequency shifting the data to baseband during processing and be determined inpost-processorsanytime data needs reprocessing from antennas_iq to rawacf. Rawacf files written by borealis will already have this correction implemented.Also made changes to the loopback tests to work with the new data format. Mock pulses were added to the driver simulator. And finally some bugs were fixed in the rx delay tests.