Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: A changed object might not affect object on same layer #102

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

nytamin
Copy link
Member

@nytamin nytamin commented Sep 3, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This is a bug fix

  • What is the current behavior? (You can also link to an open issue here)

(See unit test)
If Partial Resolving (using cache) is enabled:

On Layer L0, we have object A and B.

If object A has changed between resolves, this should affect B, since they are on the same layer and collide with eachother.
Currently, this is not taken into account during a resolve.

  • What is the new behavior (if this is a feature change)?

If Partial Resolving (using cache) is enabled:
If an object is changed between resolves, any object on the same layer (ie can be affected by the change) will be re-resolved.

  • Other information:

@nytamin nytamin requested a review from Julusian September 3, 2024 11:26
Copy link

sonarqubecloud bot commented Sep 3, 2024

@nytamin nytamin merged commit f960a1a into master Sep 4, 2024
14 checks passed
@nytamin nytamin deleted the fix/cache-bug branch September 4, 2024 10:49
nytamin added a commit to nrkno/sofie-timeline-state-resolver that referenced this pull request Sep 4, 2024
nytamin added a commit to nrkno/sofie-core that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants