Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-investigate Music Starts & Stops #58

Closed
7 tasks done
SuperHackio opened this issue Jan 8, 2023 · 0 comments
Closed
7 tasks done

Re-investigate Music Starts & Stops #58

SuperHackio opened this issue Jan 8, 2023 · 0 comments
Assignees
@SuperHackio
Labels
bug Something isn't working high-priority This issue has priority.
Milestone
Galaxy Level Engi...

Comments

@SuperHackio
Copy link
Owner

SuperHackio commented Jan 8, 2023 •
edited
Loading

Currently, I don't feel like the code that manages if music starts and stops when level changes occur is stable.

Issue #38 and Issue #21 are a massive contributor to this instability.

Below is a task list of things that need to be done, or redone:

  • Investigate Music stops and starts
  • Make Stage Music start more reliably
  • Stop the Scenario Select Music from continuing during the Galaxy Fly in
  • Assert that MainBGM is stopped by the Pause Menu when exiting the level (via Save and Quit or Return to Map)
  • Assert that the SubBGM is stopped for all stage changes(?)
  • Maybe more issues that arise during the investigation? (I know sometimes the hub music doesn't start...)
  • Test all the current fixes for reliability
@SuperHackio SuperHackio added bug Something isn't working high-priority This issue has priority. to-be-investigated labels Jan 8, 2023
@SuperHackio SuperHackio self-assigned this Jan 8, 2023
SuperHackio added a commit that referenced this issue Feb 27, 2023
@SuperHackio
Changed StageResultObj Arg 0
f7aefa6 
-1 = Save All
 0 = Save None
 1 = Save Coins Only
 2 = Save Starbits Only
 3 = Save Coins and Starbits Only
 4 = Save Comet Medal Only
 5 = Save Coins and Comet Medal Only
 6 = Save Starbits and Comet Medal Only
 7 = Save All

Improves #61
Also addresses #58
SuperHackio added a commit that referenced this issue Mar 20, 2023
@SuperHackio
Fixed hubworld music
a6e3bb6 
The hubworld music should now actually start when you return with a Power Star.
This FINALLY fixes #58 ... hopefully...

Fixed #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuperHackio SuperHackio

Labels
bug Something isn't working high-priority This issue has priority.
Projects
None yet
Milestone
Galaxy Level Engine Version 3
Development

No branches or pull requests
1 participant
@SuperHackio