Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windup & Cooldown configurability #1

Closed
dylanjkl opened this issue Jan 22, 2024 · 4 comments
Closed

Windup & Cooldown configurability #1

dylanjkl opened this issue Jan 22, 2024 · 4 comments
Labels
Feature Request A new feature you would like to see added

Comments

@dylanjkl
Copy link

I'd like to request the implementation of an optional togglable windup that makes it so when a player runs a command there is a timer until the command executes (e.g 10 seconds by default) and if the player is damaged/moved in that timeframe the command is cancelled.

I'd also like to request cooldown configurability so that the cooldown between command usage can be reduced/increased based on personal preference.
@SuperRicky14
Copy link
Owner

SuperRicky14 commented Feb 9, 2024 •
edited
Loading

Sorry for the late reply, I have been busy for a while with alot of life stuff. I aim to port TPA++ to Fabric during the weekend, I will also include this feature in the next release.

So correct me if I am wrong, you want a feature that if the player ran /TPA, they would have to wait 10 seconds (configurable) before actually sending the request.

Thank you for suggesting this feature!

@SuperRicky14 SuperRicky14 self-assigned this Feb 9, 2024
@SuperRicky14 SuperRicky14 added the Feature Request A new feature you would like to see added label Feb 9, 2024
@SuperRicky14 SuperRicky14 changed the title [Feature Request] Windup & Cooldown configurability Windup & Cooldown configurability Feb 9, 2024
@SuperRicky14 SuperRicky14 added Medium priority Medium priority issue High priority High priority issue and removed Medium priority Medium priority issue labels Feb 9, 2024
@SuperRicky14
Copy link
Owner

SuperRicky14 commented Feb 16, 2024 •
edited
Loading

Okay, I've made a working prototype of the Wind-up part in your request. But I will likely have to split this request into two different updates, since I need to rewrite a lot of the mod to get this to work correctly.

Windup's as well as some bug fixes, stability improvements and performance enhancements are out in the latest release (Check Modrinth if it's not yet out on CurseForge).

SuperRicky14 added a commit that referenced this issue Feb 19, 2024
@SuperRicky14
Refactored everything, fixed some annoying bugs and quirks, made a lo…
2216329 
…t of code asynchronous. The windups requested in issue #1 have been fixed. Additionally, the code now supports 1.20.1 - 1.20.4, (although on quilt it only works on 1.20.1 for some unknown reason).
SuperRicky14 added a commit that referenced this issue Mar 22, 2024
@SuperRicky14
Add global cooldown, re-enable cooldown code from issue #1 and add so…
9b00acc 
…me missing config options. Build is currently not stable
@SuperRicky14 SuperRicky14 removed the High priority High priority issue label Apr 1, 2024
@SuperRicky14
Copy link
Owner

Cooldowns will be implemented on the next release, Scheduled for Sunday 14/4/2024.

SuperRicky14 added a commit that referenced this issue Apr 12, 2024
@SuperRicky14
Update README.md
d1c5248 
Removed features I don't plan on doing, I want to get TPA++ to a stable state that makes it easy for others to pick up this project, and update it if they wish to. I will just fulfill the feature requested in #1.
@SuperRicky14
Copy link
Owner

Cooldowns have been finally implemented as of release 1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request A new feature you would like to see added
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dylanjkl @SuperRicky14