Override only configurable keys (partially fixes #1400) #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szborows
force-pushed
the
1400
branch
2 times, most recently
from
5afc059 to
e0265f3
Compare
|
Thanks for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1400
Idea here is to introduce "configurable keys" because (unless there are some hacks in config file) it doesn't make sense to re-bind keys that can't be configured through GUI menu.
I'm not very familiar with the code base. I'm not sure if proposed resolution is proper one. I think it's a little bit fragile because it will be easy to introduce inconsistencies (e.g. adding more items to menu but forgetting about configurable keys set in keyboard config class).
Therefore please advise where this PR should go. And please let me know if re-binding keys that aren't present in the kbd menu should be allowed.