Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Travis build #1459

Closed
wants to merge 1 commit into from
Closed

Fix Travis build #1459

wants to merge 1 commit into from

Conversation

martinvanzijl
Copy link
Contributor

Follow-up from PR#1457. Fixes the type conversion warning introduced by the PR.

@martinvanzijl
Copy link
Contributor Author

martinvanzijl commented Jul 13, 2020 •
edited
Loading

The hard part was testing this locally. I could do this with make --just-print, copy compile command to text editor, add the flag -Wconversion, then paste and execute in the shell.

If there is an easier way to test Travis build locally, please let me know.

@martinvanzijl martinvanzijl mentioned this pull request Jul 13, 2020
Merged
@tobbi
Copy link
Member

tobbi commented Jul 13, 2020

I'm sorry, @Zwatotem already fixed this with faccbca. Thanks, anyway 👍

@tobbi tobbi closed this Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinvanzijl @tobbi