Segfault fix #1697
Merged
Segfault fix #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from head
Sometimes, objects being deleted from a sector (e.g. exploding bombs) remained referenced in CollisionObjects and were accessed despite not existing. The fix works but is not really nice. It will be improved as part of a larger work on code quality. Closes SuperTux#1695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, objects being deleted from a sector (e.g. exploding bombs) remained referenced in
CollisionObjects andTilemaps and were accessed despite not existing (soCollisionObject::propagate_movementand others were called on gibberish data). That's what caused the segfault described in #1695.This fix works but it's not really nice. It will be improved as part of #1552, for now I don't really have time.