Refactor level flipping #1922
Refactor level flipping #1922
Conversation
|
Self-requested a review because I've noticed a few ways to improve the code, I'll check that in-depth and I''ll take the time to write my comments properly whenever possible (might take a few days, feel free to remind me if I seem to have forgotten). |
| @@ -33,20 +33,11 @@ class Decal; | |||
| /** Vertically or horizontally flip a level */ | |||
| class FlipLevelTransformer final : public LevelTransformer | |||
| { | |||
| public: | |||
| static Flip transform_flip(Flip flip); | |||
There was a problem hiding this comment.
Is there any upside to use this rather than taking the flip as (non-const) reference and modifying it directly that way?
(Suggesting that option as it would avoid an extra assignment in the code from callers)
src/object/platform.cpp
Outdated
| void | ||
| Platform::on_flip(float height) | ||
| { | ||
| if (Path* const path = get_path()) { |
There was a problem hiding this comment.
You have used Path* const at a few places (I won't mark them all as I usually do), which is a const pointer to a non-const object; is there a particular reason to do it this way?
|
Please rebase! |
tobbi
added
status:needs-work
|
I will do that as soon as possible |
mrkubax10
force-pushed
the
fix_unstable_tiles_at_wrong_position
branch
from
a63a6fd to
529c9e8
Compare
Fixes issues with level flipping.