Preserving players and grabbed objects between sectors #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, each sector would contain its own instances of the `Player` object for each available player. This, however, makes it tedious to preserve player data across sectors, for example, the currently grabbed object. `GameObjectManager` now supports moving objects to another `GameObjectManager`. Now, the `Level` instantiates all `Player`s in the "main" sector, and each sector, on activation, moves those players to itself, so it can manage them, essentially making players global for the level. This allows retaining the full state of all players, between sectors. Any grabbed/carried object by a player is also moved between sectors, together with the player. Additionally, a fix for the slow moving animation of grabbed objects, when teleporting while carrying them, is included. Carried objects now teleport together with the player. Fixes SuperTux#2191.
|
This pull request seems to break trampoline collision. I noticed the trampoline doesn't have The only time the 2023-08-22.14-39-53.mp4 |
mrkubax10
added
status:in-progress
mrkubax10
force-pushed
the
preserving-grabbed-objects
branch
from
6d09519 to
c686f42
Compare
Vankata453
added
status:needs-review
mrkubax10
approved these changes
Oct 30, 2023
tobbi
reviewed
Oct 30, 2023
Rusty-Box
approved these changes
Nov 16, 2023
MatusGuy
approved these changes
Nov 16, 2023
mrkubax10
removed
the
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, each sector would contain its own instances of the
Playerobject for each available player. This, however, makes it tedious to preserve player data across sectors, for example, the currently grabbed object.GameObjectManagernow supports moving objects to anotherGameObjectManager.Now, the
Levelinstantiates allPlayers in the "main" sector, and each sector, on activation, moves those players to itself, so it can manage them, essentially making players global for the level. This allows retaining the full state of all players, between sectors.Any grabbed/carried object by a player is also moved between sectors, together with the player.
Additionally, a fix for the slow moving animation of grabbed objects, when teleporting while carrying them, is included. Carried objects now teleport together with the player.
Fixes #2191.