Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupted Granito #2663

Merged
merged 39 commits into from
Nov 28, 2023
Merged

Corrupted Granito #2663

merged 39 commits into from
Nov 28, 2023

Conversation

Rusty-Box
Copy link
Member

@Rusty-Box Rusty-Box commented Oct 19, 2023

Corrupted Granit will be a hostile version of the friendly Granito NPC (#2635)
They have different forms with different behaviors.

  • Small, replacing Skullyhop as the default variant of the "hopping" enemy type
  • Big, a stationary enemy, exploding and bursting into spiky roots if Tux remains too close for too long
  • Hive, a variant of the Dispenser object used to dispense Small Corrupted Granito and visually fit in with the enviornment
  • DartTrap, a new default variant of the DartTrap enemy

Note: The original versions of certain enemy types, i.e. Skullyhops + DartTrap will remain in the game and re-added as object types!

TODO

Graphics

  • Corrupted Small Granito sprites
  • Corrupted Big Granito sprites
  • Corrupted Giant Granito (Decorative)
  • Corrupted Granito Hive sprites
  • Corrupted Dart Trap sprites
  • Particle sprites

Coding (Need help)

  • Corrupted Small Granito code tweaks
    - Immunity to fire + ice
    - Skullyhops as object type
  • Corrupted Big Granito code
  • Corrupted Granito Hive code (probably just an object type for Dropper)
    - Set Corrupted Small Granito as its default object to drop
  • Corrupted Dart Trap code tweaks
    - Skull Dart Trap as object type

Mock-up video:

Corrupted Big Granito behavior showcase (scripted):

corrupted_big_granito.mp4

Corrupted Small Granito, Hive, Dart Trap sprites showcase:

corrupted_granito_test.mp4

@Rusty-Box Rusty-Box added status:in-progress Progress has been done, but more is intended be done type:feature category:code category:design labels Oct 19, 2023
@Rusty-Box Rusty-Box added this to the 0.7.0 milestone Oct 19, 2023
@FILIPOKonGithup

This comment has been minimized.

@Rusty-Box
Copy link
Member Author

R.I.P poor Granito that got corrupted and then gets exploded. he will be missed :(

You can still rescue the survivors :)

@FILIPOKonGithup

This comment has been minimized.

@tylerandari13
Copy link
Contributor

also the ghost tree need to be renamed to the corrupted tree because the ghost forest in supertux is now renamed to the corrupted forest

I believe they were keeping the name "Ghost Tree" because it had a better ring to it.

@Rusty-Box
Copy link
Member Author

also the ghost tree need to be renamed to the corrupted tree because the ghost forest in supertux is now renamed to the corrupted forest

Technically speaking, yes you're right, however as mentioned by the comment above "Ghost Tree" just sounds better overall. If we are to change the name (which is not unlikely) it would need to be something else but "Corrupted Tree", especially since it is rather too close to "Corrupted Mr. Tree".

In my opinion, right now, "Ghost Tree" works fine still in a more metaphorical term. A tree with no "soul" a "hollow tree" (actually not a bad name, ngl.) devoid of thought and personality turning its "subjects" into the same lifeless husks.

@MatusGuy
Copy link
Member

huh???? I thought this was only reskining!! Another thing I gotta do...

@Rusty-Box
Copy link
Member Author

huh???? I thought this was only reskining!! Another thing I gotta do...

It is for te most part. The only big coding task is implementing Corrupted Big Granito. The rest is just minor things like object types and immunities

@Rusty-Box Rusty-Box added status:needs-review Work needs to be reviewed by other people and removed status:in-progress Progress has been done, but more is intended be done labels Nov 25, 2023
src/badguy/corrupted_granito.cpp Outdated Show resolved Hide resolved
src/badguy/corrupted_granito_big.cpp Outdated Show resolved Hide resolved
src/badguy/corrupted_granito_big.cpp Outdated Show resolved Hide resolved
src/badguy/corrupted_granito_big.cpp Outdated Show resolved Hide resolved
src/badguy/corrupted_granito_big.cpp Outdated Show resolved Hide resolved
src/badguy/corrupted_granito_big.cpp Outdated Show resolved Hide resolved
src/supertux/timer.cpp Outdated Show resolved Hide resolved
Copy link
Member

@tobbi tobbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May he please fix the thi

@Rusty-Box Rusty-Box requested a review from tobbi November 25, 2023 21:09
@Rusty-Box Rusty-Box mentioned this pull request Nov 27, 2023
7 tasks
@Rusty-Box Rusty-Box merged commit 82326ac into SuperTux:master Nov 28, 2023
33 checks passed
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Nov 28, 2023
@MatusGuy
Copy link
Member

Lets go

@Rusty-Box Rusty-Box deleted the corrupted-granito branch December 12, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

8 participants