-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backwards-compatible tile mappings, tile converters, tile and texture deprecation #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit remaps the tiles to their old ID mappings, prior to the breaking changes on October 2022. Co-authored-by: Vankata453 <78196474+Vankata453@users.noreply.github.com>
TODO: Move converter related actions to a separate menu with more explanation.
Preserve compatibility with some other "Castle" and "Snow" tiles.
in tiles.strf
and remove infamous DUP text
Correct stuff in `tiles.strf`.
tylerandari13
approved these changes
Nov 19, 2023
mrkubax10
reviewed
Nov 19, 2023
mrkubax10
reviewed
Nov 19, 2023
Frostwithasideofsalt
approved these changes
Dec 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autotiles seem to be the old ones but other then that it's all good. the autotiles could probably just be fixed later anyway.
[ci skip]
mrkubax10
reviewed
Dec 10, 2023
[ci skip]
mrkubax10
approved these changes
Dec 10, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Continuation of the now abandoned #2462]
Reverts the tile IDs in
tiles.strf
to ones, compatible with the old tile mappings, before the full tile overhaul. Any old tiles, which do not have a respective new version, are now marked as deprecated.Tile converters can now be used to convert all tiles on all tilemaps in a level, from the editor. Contains two stock tile converters (0.5.x Crystal Tiles, Nightly Tiles -> Present), and a new tile conversions menu (accessible from the main level editor menu). The "Nightly Tiles" converter allows for converting from the current Nightly Builds mapping, to this new, final one. The tiles of the main menu and credits levels are converted in this PR.
Introduces tile deprecation and various editor locks to prevent using such tiles, as well as show whether/where such tiles are present in a level.
Additionally introduces texture deprecation. Any image files, containing
.deprecated
right before the extension in their filename will be used, whenever the main texture (the one, which doesn't contain the.deprecated
part in its filename) does not exist, taking its place. Deprecated files do not show up on the file browsing menu.Huge thanks to Semphris for all the initial work on this, including quite a lot of tile re-mapping, organizing the full workflow, as well as the initial process of auto-generating new tile IDs and creating converters, and the implementation of the tile conversion algorithm.
Fixes #2306.