Backwards compatibility: Determine object type from sprite filename if sprite not found (WIP) #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…couldn't be found
tobbi
changed the title
tobbi
requested review from
MatusGuy,
Vankata453 and
Rusty-Box
and removed request for
MatusGuy
|
This is still missing the existing sprite paths to be honest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another backwards compatibility check: Some of the sprite paths changed in between version 0.6.3 and latest nightly. I've implemented something that checks the old sprite paths against a list of known earlier sprite paths and returns the proper object type in that case.
This only happens if the sprite path in question couldn't be found. To be honest, setting the object type for sprite paths that remained the same in between versions would also make sense, but the code is too flaky for that currently (e.g. we don't check the full path).
Tell me what you think.
Fixes #3183