Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release socket client v2.0.0 #29

Merged
merged 6 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/socket-client.ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Socket client - Configure and publish package

on:
push:
tags:
- "superviz-socket-client-[0-9]+.[0-9]+.[0-9]+**"
branches: ["master"]
paths:
- "packages/socket-client/**"
Expand Down
4 changes: 2 additions & 2 deletions packages/realtime/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
<p align="center">
<img alt="Package versions", src="https://img.shields.io/pub/v/superviz_realtime.svg">
<img alt="Discord" src="https://img.shields.io/discord/1171797567223378002">
<img alt="GitHub issues" src="https://img.shields.io/github/issues-raw/superviz/superviz">
<img alt="GitHub pull requests" src="https://img.shields.io/github/issues-pr/superviz/superviz">
<img alt="GitHub issues" src="https://img.shields.io/github/issues-raw/superviz/realtime-flutter">
<img alt="GitHub pull requests" src="https://img.shields.io/github/issues-pr/superviz/realtime-flutter">
</p>

# SuperViz Real-time
Expand Down
2 changes: 1 addition & 1 deletion packages/realtime/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ topics:
- superviz
- superviz-realtime

version: 1.0.2
version: 1.0.1

environment:
sdk: ^3.5.3
Expand Down
32 changes: 0 additions & 32 deletions packages/socket-client/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,35 +1,3 @@
## [1.1.1](https://github.com/SuperViz/realtime-flutter/compare/superviz-socket-client-1.1.0...superviz-socket-client-1.1.1) (2024-10-29)


### Bug Fixes

* incorrect package name on install dependency ([2ae5978](https://github.com/SuperViz/realtime-flutter/commit/2ae59780c0fd52cc511bbd6c31f568ceabb9d327))
* remove initial changelog register ([8b0969e](https://github.com/SuperViz/realtime-flutter/commit/8b0969e1b2207972e8e7234ac8ac7acf1e98a75a))

## [1.1.1](https://github.com/SuperViz/realtime-flutter/compare/superviz-socket-client-1.1.0...superviz-socket-client-1.1.1) (2024-10-29)


### Bug Fixes

* incorrect package name on install dependency ([2ae5978](https://github.com/SuperViz/realtime-flutter/commit/2ae59780c0fd52cc511bbd6c31f568ceabb9d327))
* remove initial changelog register ([8b0969e](https://github.com/SuperViz/realtime-flutter/commit/8b0969e1b2207972e8e7234ac8ac7acf1e98a75a))

## [1.1.1](https://github.com/SuperViz/realtime-flutter/compare/superviz-socket-client-1.1.0...superviz-socket-client-1.1.1) (2024-10-29)


### Bug Fixes

* incorrect package name on install dependency ([2ae5978](https://github.com/SuperViz/realtime-flutter/commit/2ae59780c0fd52cc511bbd6c31f568ceabb9d327))
* remove initial changelog register ([8b0969e](https://github.com/SuperViz/realtime-flutter/commit/8b0969e1b2207972e8e7234ac8ac7acf1e98a75a))

## [1.1.1](https://github.com/SuperViz/realtime-flutter/compare/superviz-socket-client-1.1.0...superviz-socket-client-1.1.1) (2024-10-29)


### Bug Fixes

* incorrect package name on install dependency ([2ae5978](https://github.com/SuperViz/realtime-flutter/commit/2ae59780c0fd52cc511bbd6c31f568ceabb9d327))
* remove initial changelog register ([8b0969e](https://github.com/SuperViz/realtime-flutter/commit/8b0969e1b2207972e8e7234ac8ac7acf1e98a75a))

# [1.1.0](https://github.com/SuperViz/realtime-flutter/compare/superviz-socket-client-1.0.0...superviz-socket-client-1.1.0) (2024-10-29)


Expand Down
3 changes: 1 addition & 2 deletions packages/socket-client/lib/src/enums/presence_events.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
enum PresenceEvents {
joinedRoom('presence.joined-room'),
leave('presence.leave'),
update('presence.update'),
error('presence.error');
update('presence.update');

final String description;

Expand Down
18 changes: 9 additions & 9 deletions packages/socket-client/lib/src/services/presence/presence.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ final class PresenceRoom {
final String _roomId;

final _presences = <PresenceEvent>{};
final _observers = <PresenceEvents, StreamController<PresenceEvent>>{};
final _observers = <String, StreamController<PresenceEvent>>{};

factory PresenceRoom.register(
SocketClient io,
Expand Down Expand Up @@ -98,11 +98,11 @@ final class PresenceRoom {

/// Register the subjects for the presence events
void _registerSubjects() {
_observers[PresenceEvents.joinedRoom] =
_observers[PresenceEvents.joinedRoom.description] =
StreamController<PresenceEvent>.broadcast();
_observers[PresenceEvents.leave] =
_observers[PresenceEvents.leave.description] =
StreamController<PresenceEvent>.broadcast();
_observers[PresenceEvents.update] =
_observers[PresenceEvents.update.description] =
StreamController<PresenceEvent>.broadcast();
}

Expand All @@ -111,7 +111,7 @@ final class PresenceRoom {
/// - `callback` - The callback to execute when the event is emitted
/// - `error` - The callback to execute when the event emits an error
void on(
PresenceEvents event,
String event,
EventCallback<PresenceEvent> callback,
) {
_observers[event]?.stream.listen(callback);
Expand All @@ -120,7 +120,7 @@ final class PresenceRoom {
/// Stop listening to an event
/// - `event` - The event to stop listening to
/// - `callback` - The callback to remove from the event
void off(PresenceEvents event) {
void off(String event) {
_observers[event]?.close();
_observers.remove(event);
_observers[event] = StreamController<PresenceEvent>();
Expand All @@ -144,7 +144,7 @@ final class PresenceRoom {

_presences.add(event);

_observers[PresenceEvents.joinedRoom]?.add(
_observers[PresenceEvents.joinedRoom.description]?.add(
PresenceEvent(
connectionId: event.connectionId,
data: event.data,
Expand All @@ -167,7 +167,7 @@ final class PresenceRoom {
description: event.name,
);
_presences.remove(event);
_observers[PresenceEvents.leave]!.add(event);
_observers[PresenceEvents.leave.description]!.add(event);
}

/// Handle the presence update event
Expand All @@ -182,7 +182,7 @@ final class PresenceRoom {
description: event.data.toString(),
);

_observers[PresenceEvents.update]!.add(
_observers[PresenceEvents.update.description]!.add(
PresenceEvent(
connectionId: event.connectionId,
data: event.data,
Expand Down
2 changes: 1 addition & 1 deletion packages/socket-client/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: superviz_socket_client
description: The superviz's socket client package
description: The dart multi-platform superviz's socket client package
repository: https://github.com/SuperViz/realtime-flutter/tree/master/packages/realtime
documentation: https://docs.superviz.com/realtime
homepage: https://superviz.com/
Expand Down