Merge pull request #703 from SuperViz/fix/kick-participant-interval

fix: retrieve user list from store to validade if room has host
SuperViz · Jul 3, 2024 · b3a06f3 · b3a06f3
2 parents 5845883 + 43522ef
commit b3a06f3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/components/video/index.test.ts b/src/components/video/index.test.ts
@@ -235,7 +235,7 @@ describe('VideoConference', () => {
 
       VideoConferenceInstance['onRealtimeParticipantsDidChange'](secondList);
 
-      expect(VideoConferenceInstance['roomState'].setHost).toHaveBeenCalledTimes(1);
+      expect(VideoConferenceInstance['roomState'].setHost).toHaveBeenCalledTimes(0);
     });
 
     test('should not set host if the participant is not me', () => {

diff --git a/src/components/video/index.ts b/src/components/video/index.ts
@@ -814,9 +814,15 @@ export class VideoConference extends BaseComponent {
     if (!this.roomState) return;
 
     const { hostId } = this.useStore(StoreType.VIDEO);
+    const { participants } = this.useStore(StoreType.GLOBAL);
+    const participantsList = Object.values(participants.value);
 
-    const participantsCanBeHost = this.participantsOnMeeting.filter((participant) => {
-      return participant.type === ParticipantType.HOST;
+    // list with all participants that have the type host and are in the meeting
+    const participantsCanBeHost = participantsList.filter((participant) => {
+      return (
+        participant.type === ParticipantType.HOST &&
+        this.participantsOnMeeting.some((p) => p.id === participant.id)
+      );
     });
 
     if (
@@ -848,7 +854,7 @@ export class VideoConference extends BaseComponent {
 
     this.onHostAvailabilityChange(!!participantsCanBeHost.length);
 
-    const hostAlreadyInRoom = participantsCanBeHost.find(
+    const hostAlreadyInRoom = participantsList.find(
       (participant) => participant?.id === hostId?.value,
     );