feat: annotation pin #338

carlossantos74 · 2023-09-25T14:41:44Z

No description provided.

…o feat/comments-pin

…/sdk into feat/comments-pin

…o feat/comments-pin

…unctions-to-comments

feat: add new functions to comments

…/comments-pin

…time

SuperViz-Dev · 2023-09-28T18:29:43Z

Total Coverage: 99.73%

Coverage Report

File	Branch	Funcs	Lines	Uncovered Lines
src
src/web-components
src/web-components/base
index.ts	100%	100%	100%
src/web-components/base/styles
icon-button.style.ts	100%	100%	100%
index.ts	100%	100%	100%
sv-hr.style.ts	100%	100%	100%
typography.style.ts	100%	100%	100%
variables.style.ts	100%	100%	100%
src/web-components/comments
comments.ts	100%	83.33%	97.10%	38, 39
index.ts	100%	100%	100%
src/web-components/comments/components
annotation-filter.ts	100%	100%	100%
annotation-item.ts	100%	100%	100%
annotation-pin.ts	100%	100%	100%
annotation-resolved.ts	100%	100%	100%
annotations.ts	100%	100%	100%
comment-input.ts	96.77%	100%	100%	56
comment-item.ts	100%	100%	100%
content.ts	100%	100%	98.75%	75
delete-comment-modal.ts	100%	100%	100%
float-button.ts	100%	100%	100%
index.ts	100%	100%	100%
topbar.ts	100%	100%	100%
types.ts	100%	100%	100%
src/web-components/comments/css
annotation-filter.style.ts	100%	100%	100%
annotation-item.style.ts	100%	100%	100%
annotation-pin.style.ts	100%	100%	100%
annotation-resolved.style.ts	100%	100%	100%
annotations.style.ts	100%	100%	100%
comment-input.style.ts	100%	100%	100%
comment-item.style.ts	100%	100%	100%
comments.style.ts	100%	100%	100%
content.style.ts	100%	100%	100%
float-button.style.ts	100%	100%	100%
index.ts	100%	100%	100%
topbar.style.ts	100%	100%	100%
src/web-components/dropdown
index.style.ts	100%	100%	100%
index.ts	100%	100%	100%
src/web-components/hello-world
index.ts	100%	100%	100%
src/web-components/icon
index.ts	100%	100%	100%
src/web-components/modal
index.ts	100%	100%	100%
modal-container.ts	100%	100%	100%
modal.ts	100%	100%	100%
src/web-components/modal/styles
index.style.ts	100%	100%	100%
src/web-components/presence-mouse
index.ts	66.67%	100%	96.33%	42, 43, 44, 59, 60, 69, 70, 76, 77
styles.ts	100%	100%	100%

SuperViz-Dev · 2023-09-28T18:32:11Z

Total Coverage: 92.87%

Coverage Report

File	Branch	Funcs	Lines	Uncovered Lines
src
shims.d.ts	100%	100%	100%
src/common
src/common/types
events.types.ts	100%	100%	100%
meeting-colors.types.ts	100%	100%	100%
participant.types.ts	100%	100%	100%
realtime.types.ts	100%	100%	100%
sdk-options.types.ts	100%	100%	100%
src/common/utils
do-request.ts	100%	100%	100%
index.ts	100%	100%	100%
logger.ts	100%	100%	100%
observer.ts	100%	100%	100%
sleep.ts	0%	100%	100%	2
src/components
index.ts	100%	50%	100%
src/components/base
index.ts	100%	100%	100%
src/components/comments
index.ts	83.33%	92.86%	96.88%	103, 367, 367, 368, 371
src/components/comments/canvas-pin-adapter
index.ts	85.71%	94.44%	96.23%	251, 253, 253, 254, 257, 284
src/components/presence-mouse
index.ts	73.91%	100%	100%	132, 83, 90, 91, 92, 93
src/components/video
index.ts	100%	100%	100%
src/core
index.ts	88.89%	100%	87.50%	49, 50, 67, 71, 73, 83
src/core/launcher
index.ts	91.67%	95%	94.68%	272, 274, 274, 275, 276, 278
src/services
src/services/api
index.ts	100%	92.31%	93.18%	82, 83, 85
src/services/auth-service
index.ts	100%	100%	100%
src/services/browser
index.ts	100%	100%	100%
src/services/config
index.ts	100%	100%	100%
src/services/connection-status
index.ts	100%	100%	100%
src/services/event-bus
index.ts	100%	100%	100%
src/services/frame-brick-layer
index.ts	100%	100%	100%
src/services/message-bridge
index.ts	93.33%	100%	100%	80
src/services/pubsub
index.ts	100%	100%	100%
src/services/realtime
index.ts	100%	100%	100%
src/services/realtime/ably
index.ts	68.85%	68.24%	78.29%	100, 104, 1060, 1069, 1071, 1071, 1072, 108, 109, 1169, 1170, 1174, 179, 259, 415, 493, 494, 496, 497, 499, 499, 512, 513, 515, 525, 526, 527, 528, 529, 529, 530, 531, 543, 553, 555, 557, 557, 557, 558, 559, 560, 560, 561, 564, 566, 566, 566, 566, 567, 568, 578, 596, 606, 648, 649, 677, 678, 679, 680, 680, 681, 683, 687, 687, 687, 687, 688, 689, 692, 692, 693, 694, 697, 698, 700, 705, 805, 805, 806, 809, 811, 811, 811, 812, 814, 868, 870, 871, 873, 875, 878, 878, 878, 878, 879, 880, 881, 883, 886, 889, 889, 890, 912, 913, 92, 937, 948, 949, 950, 951, 952, 952, 953, 955, 955, 956, 956, 959, 96, 963, 963, 963, 964, 964, 967, 970, 971
src/services/realtime/base
index.ts	100%	100%	100%
src/services/remote-config-service
index.ts	100%	100%	100%
src/services/video-conference-manager
index.ts	64.10%	86.11%	93.62%	108, 112, 113, 114, 154, 160, 192, 193, 198, 199, 200, 203, 203, 204, 206, 207, 284, 319, 320, 321, 374, 408, 519, 531, 574, 578
types.ts	100%	100%	100%

SuperViz-Dev · 2023-09-30T14:47:40Z

Total Coverage: 92.92%

Coverage Report

File	Branch	Funcs	Lines	Uncovered Lines
src
shims.d.ts	100%	100%	100%
src/common
src/common/types
events.types.ts	100%	100%	100%
meeting-colors.types.ts	100%	100%	100%
participant.types.ts	100%	100%	100%
realtime.types.ts	100%	100%	100%
sdk-options.types.ts	100%	100%	100%
src/common/utils
do-request.ts	100%	100%	100%
index.ts	100%	100%	100%
logger.ts	100%	100%	100%
observer.ts	100%	100%	100%
sleep.ts	0%	100%	100%	2
src/components
index.ts	100%	50%	100%
src/components/base
index.ts	100%	100%	100%
src/components/comments
index.ts	83.33%	92.86%	96.90%	103, 375, 375, 376, 379
src/components/comments/canvas-pin-adapter
index.ts	82.35%	95%	96.58%	229, 271, 273, 273, 274, 277, 304
src/components/presence-mouse
index.ts	73.91%	100%	100%	132, 83, 90, 91, 92, 93
src/components/video
index.ts	100%	100%	100%
src/core
index.ts	88.89%	100%	87.50%	49, 50, 67, 71, 73, 83
src/core/launcher
index.ts	91.67%	95%	94.68%	272, 274, 274, 275, 276, 278
src/services
src/services/api
index.ts	100%	92.31%	93.18%	82, 83, 85
src/services/auth-service
index.ts	100%	100%	100%
src/services/browser
index.ts	100%	100%	100%
src/services/config
index.ts	100%	100%	100%
src/services/connection-status
index.ts	100%	100%	100%
src/services/event-bus
index.ts	100%	100%	100%
src/services/frame-brick-layer
index.ts	100%	100%	100%
src/services/message-bridge
index.ts	93.33%	100%	100%	80
src/services/pubsub
index.ts	100%	100%	100%
src/services/realtime
index.ts	100%	100%	100%
src/services/realtime/ably
index.ts	68.85%	68.24%	78.29%	100, 104, 1060, 1069, 1071, 1071, 1072, 108, 109, 1169, 1170, 1174, 179, 259, 415, 493, 494, 496, 497, 499, 499, 512, 513, 515, 525, 526, 527, 528, 529, 529, 530, 531, 543, 553, 555, 557, 557, 557, 558, 559, 560, 560, 561, 564, 566, 566, 566, 566, 567, 568, 578, 596, 606, 648, 649, 677, 678, 679, 680, 680, 681, 683, 687, 687, 687, 687, 688, 689, 692, 692, 693, 694, 697, 698, 700, 705, 805, 805, 806, 809, 811, 811, 811, 812, 814, 868, 870, 871, 873, 875, 878, 878, 878, 878, 879, 880, 881, 883, 886, 889, 889, 890, 912, 913, 92, 937, 948, 949, 950, 951, 952, 952, 953, 955, 955, 956, 956, 959, 96, 963, 963, 963, 964, 964, 967, 970, 971
src/services/realtime/base
index.ts	100%	100%	100%
src/services/remote-config-service
index.ts	100%	100%	100%
src/services/video-conference-manager
index.ts	64.10%	86.11%	93.62%	108, 112, 113, 114, 154, 160, 192, 193, 198, 199, 200, 203, 203, 204, 206, 207, 284, 319, 320, 321, 374, 408, 519, 531, 574, 578
types.ts	100%	100%	100%

SuperViz-Dev · 2023-09-30T14:47:51Z

Total Coverage: 99.73%

Coverage Report

File	Branch	Funcs	Lines	Uncovered Lines
src
src/web-components
src/web-components/base
index.ts	100%	100%	100%
src/web-components/base/styles
icon-button.style.ts	100%	100%	100%
index.ts	100%	100%	100%
sv-hr.style.ts	100%	100%	100%
typography.style.ts	100%	100%	100%
variables.style.ts	100%	100%	100%
src/web-components/comments
comments.ts	100%	83.33%	97.10%	38, 39
index.ts	100%	100%	100%
src/web-components/comments/components
annotation-filter.ts	100%	100%	100%
annotation-item.ts	100%	100%	100%
annotation-pin.ts	100%	100%	100%
annotation-resolved.ts	100%	100%	100%
annotations.ts	100%	100%	100%
comment-input.ts	96.77%	100%	100%	56
comment-item.ts	100%	100%	100%
content.ts	100%	100%	98.90%	86
delete-comment-modal.ts	100%	100%	100%
float-button.ts	100%	100%	100%
index.ts	100%	100%	100%
topbar.ts	100%	100%	100%
types.ts	100%	100%	100%
src/web-components/comments/css
annotation-filter.style.ts	100%	100%	100%
annotation-item.style.ts	100%	100%	100%
annotation-pin.style.ts	100%	100%	100%
annotation-resolved.style.ts	100%	100%	100%
annotations.style.ts	100%	100%	100%
comment-input.style.ts	100%	100%	100%
comment-item.style.ts	100%	100%	100%
comments.style.ts	100%	100%	100%
content.style.ts	100%	100%	100%
float-button.style.ts	100%	100%	100%
index.ts	100%	100%	100%
topbar.style.ts	100%	100%	100%
src/web-components/dropdown
index.style.ts	100%	100%	100%
index.ts	100%	100%	100%
src/web-components/hello-world
index.ts	100%	100%	100%
src/web-components/icon
index.ts	100%	100%	100%
src/web-components/modal
index.ts	100%	100%	100%
modal-container.ts	100%	100%	100%
modal.ts	100%	100%	100%
src/web-components/modal/styles
index.style.ts	100%	100%	100%
src/web-components/presence-mouse
index.ts	66.67%	100%	96.33%	42, 43, 44, 59, 60, 69, 70, 76, 77
styles.ts	100%	100%	100%

src/web-components/comments/components/annotation-pin.ts

src/components/comments/canvas-pin-adapter/index.test.ts

src/web-components/comments/components/types.ts

SuperViz-Dev · 2023-10-02T13:36:13Z

Total Coverage: 92.92%

Coverage Report

File	Branch	Funcs	Lines	Uncovered Lines
src
shims.d.ts	100%	100%	100%
src/common
src/common/types
events.types.ts	100%	100%	100%
meeting-colors.types.ts	100%	100%	100%
participant.types.ts	100%	100%	100%
realtime.types.ts	100%	100%	100%
sdk-options.types.ts	100%	100%	100%
src/common/utils
do-request.ts	100%	100%	100%
index.ts	100%	100%	100%
logger.ts	100%	100%	100%
observer.ts	100%	100%	100%
sleep.ts	0%	100%	100%	2
src/components
index.ts	100%	50%	100%
src/components/base
index.ts	100%	100%	100%
src/components/comments
index.ts	83.33%	92.86%	96.90%	103, 375, 375, 376, 379
src/components/comments/canvas-pin-adapter
index.ts	82.35%	95%	96.58%	229, 271, 273, 273, 274, 277, 304
src/components/presence-mouse
index.ts	73.91%	100%	100%	132, 83, 90, 91, 92, 93
src/components/video
index.ts	100%	100%	100%
src/core
index.ts	88.89%	100%	87.50%	49, 50, 67, 71, 73, 83
src/core/launcher
index.ts	91.67%	95%	94.68%	272, 274, 274, 275, 276, 278
src/services
src/services/api
index.ts	100%	92.31%	93.18%	82, 83, 85
src/services/auth-service
index.ts	100%	100%	100%
src/services/browser
index.ts	100%	100%	100%
src/services/config
index.ts	100%	100%	100%
src/services/connection-status
index.ts	100%	100%	100%
src/services/event-bus
index.ts	100%	100%	100%
src/services/frame-brick-layer
index.ts	100%	100%	100%
src/services/message-bridge
index.ts	93.33%	100%	100%	80
src/services/pubsub
index.ts	100%	100%	100%
src/services/realtime
index.ts	100%	100%	100%
src/services/realtime/ably
index.ts	68.85%	68.24%	78.29%	100, 104, 1060, 1069, 1071, 1071, 1072, 108, 109, 1169, 1170, 1174, 179, 259, 415, 493, 494, 496, 497, 499, 499, 512, 513, 515, 525, 526, 527, 528, 529, 529, 530, 531, 543, 553, 555, 557, 557, 557, 558, 559, 560, 560, 561, 564, 566, 566, 566, 566, 567, 568, 578, 596, 606, 648, 649, 677, 678, 679, 680, 680, 681, 683, 687, 687, 687, 687, 688, 689, 692, 692, 693, 694, 697, 698, 700, 705, 805, 805, 806, 809, 811, 811, 811, 812, 814, 868, 870, 871, 873, 875, 878, 878, 878, 878, 879, 880, 881, 883, 886, 889, 889, 890, 912, 913, 92, 937, 948, 949, 950, 951, 952, 952, 953, 955, 955, 956, 956, 959, 96, 963, 963, 963, 964, 964, 967, 970, 971
src/services/realtime/base
index.ts	100%	100%	100%
src/services/remote-config-service
index.ts	100%	100%	100%
src/services/video-conference-manager
index.ts	64.10%	86.11%	93.62%	108, 112, 113, 114, 154, 160, 192, 193, 198, 199, 200, 203, 203, 204, 206, 207, 284, 319, 320, 321, 374, 408, 519, 531, 574, 578
types.ts	100%	100%	100%

SuperViz-Dev · 2023-10-02T13:36:31Z

Total Coverage: 99.73%

Coverage Report

File	Branch	Funcs	Lines	Uncovered Lines
src
src/web-components
src/web-components/base
index.ts	100%	100%	100%
src/web-components/base/styles
icon-button.style.ts	100%	100%	100%
index.ts	100%	100%	100%
sv-hr.style.ts	100%	100%	100%
typography.style.ts	100%	100%	100%
variables.style.ts	100%	100%	100%
src/web-components/comments
comments.ts	100%	83.33%	97.10%	38, 39
index.ts	100%	100%	100%
src/web-components/comments/components
annotation-filter.ts	100%	100%	100%
annotation-item.ts	100%	100%	100%
annotation-pin.ts	100%	100%	100%
annotation-resolved.ts	100%	100%	100%
annotations.ts	100%	100%	100%
comment-input.ts	96.77%	100%	100%	56
comment-item.ts	100%	100%	100%
content.ts	100%	100%	98.90%	86
delete-comment-modal.ts	100%	100%	100%
float-button.ts	100%	100%	100%
index.ts	100%	100%	100%
topbar.ts	100%	100%	100%
types.ts	100%	100%	100%
src/web-components/comments/css
annotation-filter.style.ts	100%	100%	100%
annotation-item.style.ts	100%	100%	100%
annotation-pin.style.ts	100%	100%	100%
annotation-resolved.style.ts	100%	100%	100%
annotations.style.ts	100%	100%	100%
comment-input.style.ts	100%	100%	100%
comment-item.style.ts	100%	100%	100%
comments.style.ts	100%	100%	100%
content.style.ts	100%	100%	100%
float-button.style.ts	100%	100%	100%
index.ts	100%	100%	100%
topbar.style.ts	100%	100%	100%
src/web-components/dropdown
index.style.ts	100%	100%	100%
index.ts	100%	100%	100%
src/web-components/hello-world
index.ts	100%	100%	100%
src/web-components/icon
index.ts	100%	100%	100%
src/web-components/modal
index.ts	100%	100%	100%
modal-container.ts	100%	100%	100%
modal.ts	100%	100%	100%
src/web-components/modal/styles
index.style.ts	100%	100%	100%
src/web-components/presence-mouse
index.ts	66.67%	100%	96.33%	42, 43, 44, 59, 60, 69, 70, 76, 77
styles.ts	100%	100%	100%

SuperViz-Dev · 2023-11-08T15:43:30Z

🎉 This PR is included in version 4.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat: add component to annotation pin

5aecf6b

carlossantos74 self-assigned this Sep 25, 2023

carlossantos74 added 4 commits September 25, 2023 11:43

Merge branch 'feat/comments-component' of github.com:SuperViz/sdk int…

39b8ed2

…o feat/comments-pin

Merge branch 'feat/comments-component' of https://github.com/SuperViz…

0ec5574

…/sdk into feat/comments-pin

feat(wip): turn pin in to mouse cursor when it in canvas

fd5fb78

Merge branch 'feat/comments-component' of github.com:SuperViz/sdk int…

07341f5

…o feat/comments-pin

SuperViz deleted a comment from SuperViz-Dev Sep 26, 2023

carlossantos74 and others added 11 commits September 27, 2023 08:31

feat(wip): add canvas adapter to handler pin in to canvas

c6d4e25

refactor: improve and fix some bugs

025ef5d

Merge branch 'refactor/improve-and-fix-some-bugs' into feat/add-new-f…

5c58ebb

…unctions-to-comments

feat: open and close comments function

7ed832a

refactor: creation of annotations and comments

59b280b

test: add new tests in annotations

a1659cb

docs: add example to pin adapters to lib.md

f88c0fa

Merge pull request #344 from SuperViz/feat/add-new-functions-to-comments

8f94b44

feat: add new functions to comments

feat(wip): add button to toggle canvas

2adfb56

Merge branch 'feat/comments-pin' of github.com:SuperViz/sdk into feat…

50db95a

…/comments-pin

feat: add toggle button to open/close comments sidebar

1ca550f

SuperViz deleted a comment from SuperViz-Dev Sep 27, 2023

carlossantos74 assigned vitorvargasdev Sep 27, 2023

carlossantos74 added 4 commits September 27, 2023 21:34

feat: active pin adapter only if comments sibar is open

8f168ce

feat: create annotation with canvas cordinates

33cd4dc

feat: update annotation list on pin adapter when it's updated on real…

55f24c7

…time

feat(wip): render annotations on canvas

956770d

carlossantos74 added 7 commits September 28, 2023 13:29

feat: render pins into canvas

84e543c

feat: create temporary pin while a new annotation is creating

cc80ccf

fix: fix coordinates to save

92330e5

feat: remove all pins when isActive turned false

ff8c5d1

fix: annotations styles

65c8ac1

fix: coordinates spell check

6d38698

test: improve test coverage

154fa10

SuperViz deleted a comment from SuperViz-Dev Sep 28, 2023

test: fix annotation-pin tests

86352f2

feat: select annotation by pin

5ab9481

carlossantos74 marked this pull request as ready for review October 2, 2023 11:09

carlossantos74 requested review from vitorvargasdev and afonsovinicius October 2, 2023 11:40

vitorvargasdev suggested changes Oct 2, 2023

View reviewed changes

src/web-components/comments/components/annotation-pin.ts Outdated Show resolved Hide resolved

src/components/comments/canvas-pin-adapter/index.test.ts Show resolved Hide resolved

src/web-components/comments/components/types.ts Outdated Show resolved Hide resolved

refactor: pin option case and unecessary imports

3b67ca9

vitorvargasdev approved these changes Oct 2, 2023

View reviewed changes

afonsovinicius approved these changes Oct 2, 2023

View reviewed changes

carlossantos74 merged commit 06adabb into feat/comments-component Oct 2, 2023
3 checks passed

SuperViz-Dev added the released label Nov 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: annotation pin #338

feat: annotation pin #338

carlossantos74 commented Sep 25, 2023

SuperViz-Dev commented Sep 28, 2023

SuperViz-Dev commented Sep 28, 2023

SuperViz-Dev commented Sep 30, 2023

SuperViz-Dev commented Sep 30, 2023

SuperViz-Dev commented Oct 2, 2023

SuperViz-Dev commented Oct 2, 2023

SuperViz-Dev commented Nov 8, 2023

feat: annotation pin #338

feat: annotation pin #338

Conversation

carlossantos74 commented Sep 25, 2023

SuperViz-Dev commented Sep 28, 2023

SuperViz-Dev commented Sep 28, 2023

SuperViz-Dev commented Sep 30, 2023

SuperViz-Dev commented Sep 30, 2023

SuperViz-Dev commented Oct 2, 2023

SuperViz-Dev commented Oct 2, 2023

SuperViz-Dev commented Nov 8, 2023