Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

feat: hide temp pin click #505

Merged
merged 5 commits into from
Jan 15, 2024
Merged

feat: hide temp pin click #505

merged 5 commits into from
Jan 15, 2024

Conversation

Raspincel
Copy link
Contributor

In Comments, both with CanvasPin and HTMLPin:

  • If creating an annotation and then clicking on another part of the screen (say, for example, in the comments sidebar), hide temporary pin and input
  • Do not do anything at all when participant creates an annotation. No sort of translation, nor anything

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 98.54%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 100% 100% 80.52% 29, 30, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/comments
   comments.ts 92.86% 87.50% 98.26% 45, 46, 62
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 100% 96.64% 154, 155, 156, 157, 158, 159, 160, 161
   annotation-pin.ts 100% 100% 94.24% 104, 109, 110, 111, 112, 163, 164, 165, 228, 62, 63, 64, 65, 66
   annotation-resolved.ts 100% 100% 100%
   comment-input.ts 100% 100% 99.12% 93, 94
   comment-item.ts 100% 100% 100%
   content.ts 96.15% 81.82% 88.71% 104, 105, 35, 36, 39, 40, 41, 47, 48, 49, 63, 74, 75, 76, 77
   delete-comment-modal.ts 100% 100% 100%
   float-button.ts 100% 100% 96.15% 41, 61, 62
   index.ts 100% 100% 100%
   topbar.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-pin.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   float-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   powered-by.style.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/comments/utils
   watermark.ts 100% 100% 90.77% 17, 18, 19, 20, 21, 22
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 98.47% 100% 99.58% 262, 408, 71, 74
   types.ts 100% 100% 100%
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/tooltip
   index.style.ts 100% 100% 100%
   index.ts 96.77% 100% 100% 82
   types.ts 100% 100% 100%
src/web-components/who-is-online
   index.ts 100% 100% 100%
   who-is-online.ts 97.12% 100% 99.47% 327, 327, 327, 328, 329
src/web-components/who-is-online/components
   dropdown.ts 94.87% 95.45% 98.95% 133, 134, 165, 165, 177, 177, 178, 179
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/who-is-online/css
   dropdown.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   who-is-online-style.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 92.29%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/types
   colors.types.ts 100% 100% 100%
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 87.50% 20
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observable.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
src/components
   index.ts 100% 85.71% 100%
   types.ts 100% 100% 100%
src/components/base
   index.ts 100% 100% 100%
src/components/comments
   index.ts 92.59% 97.14% 98.51% 139, 198, 451, 548, 564
   types.ts 100% 100% 100%
src/components/comments/canvas-pin-adapter
   index.ts 64.71% 88.89% 90.18% 196, 197, 198, 247, 247, 247, 247, 248, 249, 252, 252, 253, 256, 322, 323, 325, 325, 325, 327, 327, 328, 330, 331, 334, 336, 400, 413, 417, 430, 451, 476, 496, 497, 508, 510, 510, 510, 510, 512, 513
src/components/comments/html-pin-adapter
   index.ts 96.70% 96.23% 98.49% 467, 469, 470, 470, 470, 470, 472, 473
src/components/presence-mouse
   index.ts 80.65% 100% 100% 206, 206, 206, 206, 276, 286
src/components/realtime
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/components/video
   index.ts 97.06% 100% 100% 197
src/components/who-is-online
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/core
   index.ts 95.65% 80% 89.36% 100, 121, 134, 140, 79, 80
src/core/launcher
   index.ts 93.75% 100% 100% 251
src/services
src/services/api
   index.ts 100% 88.24% 88.89% 100, 101, 103, 109, 110, 111, 112
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/event-bus
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/limits
   index.ts 75% 100% 100% 10
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/pubsub
   index.ts 100% 90% 100%
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 54.71% 62.83% 70.99% 1005, 1006, 102, 1046, 1047, 1058, 106, 1062, 1066, 110, 1102, 1161, 1170, 1172, 1172, 1173, 118, 122, 123, 1271, 1275, 1276, 1277, 1311, 1312, 1316, 1322, 1322, 1323, 1326, 1328, 1329, 1330, 1333, 1337, 1337, 1339, 1340, 1344, 1344, 1344, 1346, 1350, 1352, 1358, 1362, 1363, 1373, 1375, 1381, 1398, 1398, 1400, 1401, 1402, 1433, 1433, 1434, 1439, 1440, 1443, 1446, 1446, 1447, 1448, 1450, 1451, 1452, 1455, 1459, 1459, 1461, 1462, 1466, 1466, 1466, 1466, 1468, 1468, 1468, 1470, 1478, 1478, 1480, 1484, 1484, 1485, 1488, 1490, 1502, 1503, 1513, 1515, 1525, 1527, 1527, 1528, 1531, 196, 281, 422, 424, 434, 447, 460, 460, 462, 504, 514, 515, 536, 537, 539, 540, 542, 542, 543, 557, 559, 562, 564, 574, 575, 576, 577, 578, 578, 579, 580, 592, 602, 604, 606, 608, 609, 609, 615, 615, 615, 615, 615, 616, 618, 620, 623, 623, 623, 623, 623, 624, 626, 627, 627, 627, 627, 627, 628, 629, 629, 629, 629, 629, 630, 631, 631, 632, 632, 632, 632, 637, 639, 642, 644, 644, 644, 644, 645, 647, 664, 665, 675, 676, 686, 728, 729, 758, 760, 761, 762, 762, 763, 766, 773, 773, 774, 774, 776, 776, 776, 779, 780, 783, 783, 784, 785, 788, 789, 791, 796, 896, 896, 897, 900, 902, 902, 902, 903, 905, 959, 961, 962, 964, 966, 968, 968, 968, 968, 969, 970, 971, 974, 975, 978, 981, 981, 981, 981, 982
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 100% 100%
src/services/video-conference-manager
   index.ts 64.10% 86.11% 93.62% 117, 120, 121, 122, 163, 168, 200, 201, 206, 207, 208, 211, 211, 212, 214, 215, 292, 327, 328, 329, 382, 416, 527, 539, 582, 586
   types.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 98.54%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 100% 100% 80.52% 29, 30, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/comments
   comments.ts 92.86% 87.50% 98.26% 45, 46, 62
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 100% 96.64% 154, 155, 156, 157, 158, 159, 160, 161
   annotation-pin.ts 100% 100% 94.24% 104, 109, 110, 111, 112, 163, 164, 165, 228, 62, 63, 64, 65, 66
   annotation-resolved.ts 100% 100% 100%
   comment-input.ts 100% 100% 99.12% 93, 94
   comment-item.ts 100% 100% 100%
   content.ts 96.15% 81.82% 88.71% 104, 105, 35, 36, 39, 40, 41, 47, 48, 49, 63, 74, 75, 76, 77
   delete-comment-modal.ts 100% 100% 100%
   float-button.ts 100% 100% 96.15% 41, 61, 62
   index.ts 100% 100% 100%
   topbar.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-pin.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   float-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   powered-by.style.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/comments/utils
   watermark.ts 100% 100% 90.77% 17, 18, 19, 20, 21, 22
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 98.47% 100% 99.58% 262, 408, 71, 74
   types.ts 100% 100% 100%
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/tooltip
   index.style.ts 100% 100% 100%
   index.ts 96.77% 100% 100% 82
   types.ts 100% 100% 100%
src/web-components/who-is-online
   index.ts 100% 100% 100%
   who-is-online.ts 97.12% 100% 99.47% 327, 327, 327, 328, 329
src/web-components/who-is-online/components
   dropdown.ts 94.87% 95.45% 98.95% 133, 134, 165, 165, 177, 177, 178, 179
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/who-is-online/css
   dropdown.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   who-is-online-style.ts 100% 100% 100%

@carlossantos74 carlossantos74 merged commit 17b9274 into lab Jan 15, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 15, 2024
@carlossantos74
BUILD: (17b9274) Merge pull request #505 from SuperViz/feat/hide-temp…
9b87a4a 
…-pin-click

feat: hide temp pin click
@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 5.3.0-lab.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 5.3.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 5.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossantos74 carlossantos74 carlossantos74 approved these changes

@vitorvargasdev vitorvargasdev Awaiting requested review from vitorvargasdev

@afonsovinicius afonsovinicius Awaiting requested review from afonsovinicius

Assignees
No one assigned
Labels
released on @beta released on @lab released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Raspincel @SuperViz-Dev @carlossantos74