Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

Slot assignments and participant updates fixes 🎉 #570

Merged
merged 47 commits into from
Feb 16, 2024
Merged

Slot assignments and participant updates fixes 🎉 #570

merged 47 commits into from
Feb 16, 2024

Conversation

carlossantos74
Copy link
Collaborator

No description provided.

Raspincel and others added 30 commits February 6, 2024 21:17
@Raspincel
feat: change dropdown side according to if it is too high or too low
7acb533
@Raspincel
fix: call event of closing threads another name so it doesn't get cal…
d81cc19 
…led when dropdown closes
@Raspincel
fix: remove allowSetSize property from superviz-icon component
b1a46eb
@Raspincel
fix: rename event in test
74150b0
@Raspincel
fix: correct modal tests
2e89796
@carlossantos74
Merge pull request #556 from SuperViz/fix/rename-close-threads-event
2c90cb4 
fix: call event of closing threads another name
@carlossantos74
Merge pull request #554 from SuperViz/feat/improve-wio-dropdown
6974bcf 
feat: change dropdown side according to if it is too high or too low
@carlossantos74
fix: remove throttle for participants update
5d0f756
@carlossantos74
Merge pull request #557 from SuperViz/refactor/slot-index-logic
d8cf37e 
fix: remove throttle for participants update
@carlossantos74
Merge pull request #555 from SuperViz/fix/remove-allowSetSize
b002ab4 
fix: remove allowSetSize property from superviz-icon component
@carlossantos74
Merge pull request #558 from SuperViz/main
ec86506 
update lab version
@carlossantos74
fix: slot assignment
387220c
@carlossantos74
fix: review color matchers
f9d3416
@Raspincel
Merge pull request #559 from SuperViz/refactor/slot-index-logic
c547960 
fix: slot assignment
@Raspincel
fix: show correct tooltip
bba7660
@carlossantos74
Merge pull request #560 from SuperViz/fix/show-correct-tooltip
6206f43 
fix: show correct tooltip
@Raspincel
feat: indicate state of pinActive visually through button colors
a7bdf6c
@carlossantos74
Merge pull request #561 from SuperViz/feat/indicate-pinActive-state
cb65438 
feat: indicate state of pinActive visually through button colors
@Raspincel
feat: add close comment input button
05aafba
@Raspincel
fix: change icons colors to sv-gray-600
3b366ae
@Raspincel
feat: change text for floating button and improve animation
9cbab43
@Raspincel
fix: correct tests
fee20c5
@Raspincel
fix: change 'Cancel' to 'Close'
7a5923c
@carlossantos74
Merge pull request #562 from SuperViz/feat/change-button-text
2766db5 
feat: change button text
@Raspincel
feat: add outline when hovering normal elements
f323b13
@Raspincel
feat: remove outline if pin is set to inactive
3d27816
@Raspincel
feat: improve ellipse wrapper box
e9ccf60
@Raspincel
feat: handle outline when element is an ellipse
767d8c4
@Raspincel
fix: change text cancel to comment and close to cancel in floating bu…
71e0c23 
…tton
@Raspincel
feat: create tests for handling svg elements in html pin
0f54f74
Raspincel and others added 17 commits February 15, 2024 08:50
@Raspincel
feat: allow user to change color of outline
339b66a
@Raspincel
feat: publish events when presence controls are used
9863333
@Raspincel
feat: call user callback if there is any
db079f2
@Raspincel
feat: increase user name font size in comments
7edebc9
@Raspincel
fix: set selected pin active even if not in pin active mode
9606e64
@Raspincel
fix: change expected value in test
968a282
@carlossantos74
Merge pull request #563 from SuperViz/feat/html-pin-outline
e37f4ab 
feat: comments html pin outline
@carlossantos74
Merge pull request #566 from SuperViz/feat/allow-callback-presence-html
38b3af1 
feat: call user callback if there is any
@Raspincel
Merge branch 'lab' into fix/increase-name-font-size
9ae3afb
@Raspincel
fix: remove unnecessary comment
ef4e750
@carlossantos74
Merge pull request #567 from SuperViz/fix/increase-name-font-size
8c7ac80 
fix: increase name font size
@carlossantos74
Merge pull request #565 from SuperViz/feat/publish-wio-events
a74a8e9 
feat: publish events when presence controls are used
@Raspincel
feat: merge tests-svg-html-pin into lab
6d4d26f
@carlossantos74
Merge pull request #568 from SuperViz/main
bbbb3cf 
Merge pull request #553 from SuperViz/beta
@Raspincel
fix: fix html pin tests
f32fb81
@carlossantos74
Merge pull request #564 from SuperViz/feat/tests-svg-html-pin
37842bf 
feat: tests svg html pin
@carlossantos74
Merge pull request #569 from SuperViz/lab
4de039a 
Slot assignments and participant updates fixes 🎉
@SuperViz-Dev
Copy link
Contributor

Total Coverage: 93.74%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/types
   colors.types.ts 100% 100% 100%
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 87.50% 20
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observable.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
src/components
   index.ts 100% 85.71% 100%
   types.ts 100% 100% 100%
src/components/base
   index.ts 100% 100% 100%
src/components/comments
   index.ts 94.74% 93.18% 96.33% 233, 292, 351, 352, 353, 355, 475, 513, 582, 695, 711
   types.ts 100% 100% 100%
src/components/comments/canvas-pin-adapter
   index.ts 58.62% 85.71% 88.19% 205, 206, 207, 254, 254, 254, 254, 255, 256, 259, 259, 260, 263, 333, 334, 336, 336, 336, 338, 338, 339, 341, 342, 345, 347, 412, 423, 434, 438, 451, 472, 497, 517, 518, 529, 530, 531, 532, 533, 533, 533, 533, 533, 535, 535, 536, 536, 536, 536, 540, 542, 543
src/components/comments/html-pin-adapter
   index.ts 92.73% 98.28% 97.05% 284, 285, 286, 372, 481, 482, 503, 504, 506, 506, 508, 509, 511, 511, 511, 511, 513, 514, 804, 805, 806
src/components/presence-mouse
   index.ts 100% 100% 100%
src/components/presence-mouse/canvas
   index.ts 80.65% 100% 100% 205, 205, 205, 205, 275, 285
src/components/presence-mouse/html
   index.ts 98.33% 100% 100% 801
src/components/realtime
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/components/video
   index.ts 94.34% 98.04% 98.24% 211, 620, 725, 725, 728, 728, 730
src/components/who-is-online
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/core
   index.ts 86.96% 57.14% 76% 114, 117, 121, 122, 124, 137, 139, 145, 69, 69, 71, 72, 73, 93, 94
src/core/launcher
   index.ts 94.12% 95.45% 98.64% 283, 95, 99
src/services
src/services/api
   index.ts 100% 88.24% 88.33% 102, 103, 105, 111, 112, 113, 114
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/event-bus
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/limits
   index.ts 75% 100% 100% 10
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/pubsub
   index.ts 100% 90% 100%
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 65.89% 65.42% 74.54% 1005, 101, 105, 109, 1094, 1098, 1099, 1100, 1134, 1135, 1139, 1145, 1145, 1146, 1149, 1151, 1152, 1153, 1156, 1160, 1160, 1162, 1163, 1167, 1167, 1167, 1169, 117, 1173, 1175, 1181, 1185, 1186, 1196, 1198, 1204, 121, 122, 1221, 1221, 1223, 1224, 1225, 1256, 1256, 1257, 1262, 1263, 1266, 1269, 1269, 1270, 1271, 1273, 1274, 1275, 1278, 1282, 1282, 1284, 1285, 1289, 1289, 1289, 1289, 1291, 1291, 1291, 1293, 1301, 1301, 1303, 1307, 1307, 1308, 1311, 1313, 1325, 1326, 1336, 1338, 1348, 1350, 1350, 1351, 1354, 194, 260, 270, 411, 413, 414, 427, 440, 440, 442, 454, 455, 456, 507, 508, 510, 511, 513, 513, 514, 528, 530, 533, 535, 545, 546, 547, 548, 549, 549, 550, 551, 563, 565, 575, 577, 579, 581, 581, 581, 581, 582, 584, 601, 602, 612, 613, 623, 665, 666, 777, 777, 778, 781, 783, 783, 783, 784, 786, 848, 869, 869, 870, 889, 889, 891, 891, 892, 895, 899, 899, 899, 899, 900, 901, 904, 905, 907, 908, 908, 910, 945
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 100% 100%
src/services/video-conference-manager
   index.ts 61.90% 84.21% 93.53% 121, 124, 125, 126, 169, 174, 206, 207, 212, 213, 214, 217, 217, 218, 220, 221, 299, 311, 333, 360, 361, 362, 415, 449, 560, 572, 615, 619, 678
   types.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 96.59%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 100% 100% 80.52% 29, 30, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/base/utils
   importStyle.ts 66.67% 100% 100% 3
src/web-components/comments
   comments.ts 94.44% 90% 98.55% 54, 55, 71
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 100% 96.86% 165, 166, 167, 168, 169, 170, 171, 172
   annotation-pin.ts 100% 100% 94.40% 108, 113, 114, 115, 116, 167, 168, 169, 235, 66, 67, 68, 69, 70
   annotation-resolved.ts 100% 100% 100%
   comment-input.ts 100% 96.43% 96.56% 124, 125, 126, 127, 209, 210, 211, 214, 215, 243, 244, 336, 337, 351, 352
   comment-item.ts 100% 58.82% 75.56% 100, 101, 102, 103, 104, 105, 106, 107, 108, 111, 112, 120, 121, 122, 151, 152, 153, 154, 155, 156, 157, 158, 161, 162, 163, 164, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 198, 199, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 96, 97, 98, 99
   content.ts 96.15% 81.82% 89.15% 108, 109, 39, 40, 43, 44, 45, 51, 52, 53, 67, 78, 79, 80, 81
   delete-comment-modal.ts 100% 100% 100%
   float-button.ts 100% 90.91% 92.13% 57, 66, 72, 73, 74, 75, 76, 77, 95, 96
   index.ts 100% 100% 100%
   mention-list.ts 100% 100% 100%
   topbar.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-pin.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   float-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   mention-list.style.ts 100% 100% 100%
   powered-by.style.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/comments/utils
   autocomplete-handler.ts 100% 100% 98.29% 25, 26
   mention-handler.ts 100% 100% 100%
   watermark.ts 100% 100% 86.15% 15, 16, 17, 18, 19, 20, 21, 22, 23
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 92.73% 100% 97.60% 154, 155, 156, 157, 158, 159, 187, 221, 251, 83, 86
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/tooltip
   index.style.ts 100% 100% 100%
   index.ts 85.19% 100% 95.15% 109, 110, 111, 112, 114, 115, 116, 117, 152, 156, 221, 222, 223, 224, 88, 90, 91, 92, 94, 95, 96
   types.ts 100% 100% 100%
src/web-components/who-is-online
   index.ts 100% 100% 100%
   who-is-online.ts 94% 100% 97.88% 148, 149, 150, 160, 161, 162, 178, 179, 180, 316, 316, 316, 317, 318
src/web-components/who-is-online/components
   dropdown.ts 91.67% 94.74% 97.34% 133, 134, 135, 136, 137, 138, 170, 170, 182, 182, 183, 184
   index.ts 100% 100% 100%
   messages.ts 100% 78.57% 97.12% 114, 115, 123, 124, 132, 133
   types.ts 100% 100% 100%
src/web-components/who-is-online/css
   dropdown.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   messages.style.ts 100% 100% 100%
   who-is-online-style.ts 100% 100% 100%

@carlossantos74 carlossantos74 merged commit d5b05bc into main Feb 16, 2024
6 checks passed
@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 5.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossantos74 @SuperViz-Dev @Raspincel