Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

feat: mouse follow and wio flag #620

Merged
merged 3 commits into from
Apr 2, 2024
Merged

feat: mouse follow and wio flag #620

merged 3 commits into from
Apr 2, 2024

Conversation

Raspincel
Copy link
Contributor

  • Update mouse positions immediately after using transform on them, instead of waiting for next participant interaction
  • Change what coordinates exactly the HTML mouse component calls the user callback with in goToPresence (Before: Coordinates relative to the user viewport. Now: Coordinates relative to the container)
  • Create flag for disabling presence controls in WIO even when using it with presence

@Raspincel Raspincel requested a review from vitorvargasdev April 2, 2024 10:42
@github-actions github-actions bot deleted a comment from SuperViz-Dev Apr 2, 2024
@SuperViz-Dev
Copy link
Contributor

Total Coverage: 92.47%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/types
   colors.types.ts 100% 100% 100%
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
   stores.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 87.50% 20
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observable.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
   use-store.ts 66.67% 100% 100% 30
src/components
   index.ts 100% 85.71% 100%
   types.ts 100% 100% 100%
src/components/base
   index.ts 100% 100% 100%
src/components/comments
   index.ts 94.44% 93.33% 96.40% 242, 301, 360, 361, 362, 364, 482, 520, 589, 702, 718
   types.ts 100% 100% 100%
src/components/comments/canvas-pin-adapter
   index.ts 54.55% 85.71% 88.09% 202, 249, 249, 249, 249, 250, 251, 254, 254, 255, 258, 328, 329, 331, 331, 331, 333, 333, 334, 336, 337, 340, 342, 391, 392, 393, 412, 423, 434, 438, 451, 472, 497, 517, 518, 529, 530, 531, 532, 533, 533, 533, 533, 533, 535, 535, 536, 536, 536, 536, 540, 542, 543
src/components/comments/html-pin-adapter
   index.ts 91.59% 96.55% 96.35% 277, 278, 279, 336, 363, 470, 471, 492, 493, 495, 495, 497, 498, 500, 500, 500, 500, 502, 503, 718, 719, 720, 797, 798, 799
src/components/presence-mouse
   index.ts 50% 100% 90% 10, 11
   types.ts 100% 100% 100%
src/components/presence-mouse/canvas
   index.ts 70.97% 76.19% 86.67% 102, 103, 104, 105, 125, 125, 127, 151, 154, 154, 155, 156, 230, 230, 230, 230, 290, 378, 69, 70, 71, 72, 73, 75, 76, 77, 78, 87, 88, 92, 93
src/components/presence-mouse/html
   index.ts 89.19% 96.97% 99.38% 245, 245, 247, 267, 519, 636
src/components/realtime
   index.ts 76.92% 81.25% 86.67% 169, 169, 171, 173, 174, 177, 179, 183, 184, 205, 82, 83, 97
   types.ts 100% 100% 100%
src/components/video
   index.ts 92.73% 98.08% 98.30% 213, 519, 647, 752, 752, 755, 755, 757
src/components/who-is-online
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/core
   index.ts 80% 57.14% 76.47% 114, 117, 121, 122, 124, 129, 129, 137, 139, 145, 69, 69, 71, 72, 73, 93, 94
src/core/launcher
   index.ts 75% 86.96% 89.94% 117, 119, 120, 124, 127, 299, 299, 300, 313, 314, 358, 358, 361, 362, 364, 369, 371, 373, 413, 421, 422, 425
src/services
src/services/api
   index.ts 100% 88.24% 88.33% 102, 103, 105, 111, 112, 113, 114
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/event-bus
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/io
   index.ts 100% 100% 100%
src/services/limits
   index.ts 75% 100% 100% 10
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 65.31% 66.67% 72.77% 1000, 1003, 1003, 1004, 1005, 1007, 1008, 1009, 1012, 1016, 1016, 1018, 1019, 1023, 1023, 1023, 1023, 1025, 1025, 1025, 1027, 103, 1035, 1035, 1037, 1041, 1041, 1042, 1045, 1047, 1059, 1060, 1070, 1072, 1082, 1084, 1084, 1085, 1088, 111, 115, 116, 188, 253, 263, 313, 314, 322, 322, 323, 324, 327, 329, 329, 330, 333, 404, 406, 407, 417, 418, 419, 470, 471, 472, 473, 474, 474, 475, 476, 488, 490, 500, 502, 504, 506, 506, 506, 506, 507, 509, 526, 527, 537, 538, 548, 590, 591, 702, 702, 703, 706, 708, 708, 708, 709, 711, 747, 878, 879, 880, 881, 883, 886, 887, 888, 890, 891, 893, 893, 893, 894, 895, 897, 898, 899, 903, 903, 904, 907, 924, 925, 926, 933, 934, 938, 95, 955, 955, 957, 958, 959, 99, 990, 990, 991, 996, 997
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 100% 100%
src/services/slot
   index.ts 50% 83.33% 75.68% 44, 80, 80, 80, 80, 82, 82, 83, 84, 85, 88, 91, 91, 91, 91, 92, 93
src/services/stores
   index.ts 100% 100% 100%
src/services/stores/common
   utils.ts 100% 100% 100%
src/services/stores/global
   index.ts 0% 100% 94.74% 14, 15
src/services/stores/subject
   index.ts 100% 100% 100%
src/services/stores/who-is-online
   index.ts 0% 66.67% 80% 11, 12, 19, 20
src/services/video-conference-manager
   index.ts 61.90% 84.21% 93.53% 121, 124, 125, 126, 169, 174, 206, 207, 212, 213, 214, 217, 217, 218, 220, 221, 299, 311, 333, 360, 361, 362, 415, 449, 560, 572, 615, 619, 678
   types.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 97.47%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 75% 100% 83.52% 28, 32, 33, 34, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/base/utils
   importStyle.ts 66.67% 100% 100% 3
src/web-components/comments
   comments.ts 88.24% 76.92% 87.65% 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 135, 64, 65, 66, 79, 80, 92, 93, 94, 95, 96, 97
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 96.43% 96.73% 181, 182, 183, 184, 185, 186, 187, 188, 232, 233
   annotation-pin.ts 100% 100% 95.19% 118, 123, 124, 125, 126, 183, 184, 185, 74, 75, 76, 77, 78
   annotation-resolved.ts 100% 100% 100%
   comment-input.ts 100% 96.55% 97.63% 221, 222, 223, 226, 227, 255, 256, 353, 354, 368, 369
   comment-item.ts 100% 100% 100%
   content.ts 96.15% 81.82% 89.15% 108, 109, 39, 40, 43, 44, 45, 51, 52, 53, 67, 78, 79, 80, 81
   delete-comment-modal.ts 100% 100% 100%
   float-button.ts 100% 100% 87.65% 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 50, 51, 55, 56, 72, 81
   index.ts 100% 100% 100%
   mention-list.ts 100% 100% 100%
   topbar.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-pin.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   float-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   mention-list.style.ts 100% 100% 100%
   powered-by.style.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/comments/utils
   autocomplete-handler.ts 100% 100% 98.29% 25, 26
   mention-handler.ts 100% 100% 100%
   watermark.ts 100% 100% 86.15% 15, 16, 17, 18, 19, 20, 21, 22, 23
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 92.73% 100% 97.60% 154, 155, 156, 157, 158, 159, 187, 221, 251, 83, 86
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/tooltip
   index.style.ts 100% 100% 100%
   index.ts 85.19% 100% 95.15% 109, 110, 111, 112, 114, 115, 116, 117, 152, 156, 221, 222, 223, 224, 88, 90, 91, 92, 94, 95, 96
   types.ts 100% 100% 100%
src/web-components/who-is-online
   index.ts 100% 100% 100%
   who-is-online.ts 89.62% 100% 97.07% 170, 171, 172, 182, 183, 184, 200, 201, 202, 243, 266, 326, 346, 347, 347, 348, 349, 350, 351, 56, 57, 62, 63
src/web-components/who-is-online/components
   dropdown.ts 90.20% 94.74% 96.78% 139, 140, 141, 142, 143, 144, 176, 176, 189, 190, 190, 191, 192, 193, 194
   index.ts 100% 100% 100%
   messages.ts 100% 80% 97.24% 123, 124, 132, 133, 141, 142
   types.ts 100% 100% 100%
src/web-components/who-is-online/css
   dropdown.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   messages.style.ts 100% 100% 100%
   who-is-online-style.ts 100% 100% 100%

@Raspincel Raspincel merged commit 7f93134 into lab Apr 2, 2024
4 checks passed
@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 5.9.0-lab.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 6.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitorvargasdev vitorvargasdev vitorvargasdev approved these changes

Assignees
No one assigned
Labels
released on @beta released on @lab released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Raspincel @SuperViz-Dev @vitorvargasdev