This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
fix: ensure that video frame is destroyed #652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Total Coverage: 93.24% Coverage Report
|
Total Coverage: 97.35% Coverage Report
|
Raspincel
approved these changes
May 8, 2024
🎉 This PR is included in version 6.1.0-beta.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.1.0-lab.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that didn't destroy the video frame when the participant leaves the meeting.
Explanation: Sometimes the process to destroy the video took too long, it's cause the video services lost the frame reference, causing an error that made it impossible to get destroyed.
To solve: We make sure that the first thing we do when the participant leaves the meeting room is to destroy the frame. This will prevent the error and ensure that the meeting overlay is destroyed.